Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Include frozen indices #118555

Merged
merged 4 commits into from
Nov 19, 2021
Merged

[Lens] Include frozen indices #118555

merged 4 commits into from
Nov 19, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #117616 the same way as #118022

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v8.1.0 labels Nov 15, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review November 15, 2021 18:41
@flash1293 flash1293 requested a review from a team as a code owner November 15, 2021 18:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test it because I couldn't manage to make this work: POST /sampledata/_freeze , but the code looks good for me! 🆗

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #26 / machine learning anomaly detection custom urls tests Discover type custom URL opens Discover page from test link in the edit job flyout
  • [job] [logs] Default CI Group #7 / reporting management app Listing of Reports Paginates historical reports

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 19, 2021
@flash1293 flash1293 merged commit 1ac885e into elastic:main Nov 19, 2021
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2021
@flash1293 @kibanamachine
include frozen index (elastic#118555)
d94a059 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 19, 2021
@kibanamachine @flash1293
include frozen index (#118555) (#119194)
378c5ed 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
@dej611 dej611 mentioned this pull request Nov 19, 2021
Closed
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
@flash1293 @kibanamachine @TinLe
include frozen index (elastic#118555)
b6ca396 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@flash1293 @kibanamachine @dmlemeshko
include frozen index (#118555)
f2eba4a 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lens shows "empty dataset" when time range includes only frozen indices
5 participants
@flash1293 @elasticmachine @kibana-ci @kibanamachine @mbondyra