Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] data view api docs - index patterns => data views #119415

Merged
merged 13 commits into from
Dec 1, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Nov 23, 2021

Summary

Update data view api (and one dashboards api) docs to reflect index patterns => data views rename

@mattkime mattkime changed the title initial pass at changing urls and anchors [data views] data view api docs - index patterns => data views Nov 24, 2021
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages v8.0.0 v8.1.0 docs release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesSv labels Nov 24, 2021
@mattkime mattkime marked this pull request as ready for review November 24, 2021 05:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime mattkime requested a review from vadimkibana November 29, 2021 21:58
@@ -0,0 +1,42 @@
[[data-views-api]]
Copy link
Contributor

@Dosant Dosant Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes docs URLs, correct?

In this case we should add this to redirects: https://github.com/elastic/kibana/blob/main/docs/redirects.asciidoc

(for all of the pages, I think)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@mattkime mattkime added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 1, 2021
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #4 / Spaces app Enter Space allows user to navigate to different spaces, respecting the configured default route

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit eb2ddcd into elastic:main Dec 1, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 1, 2021
…ic#119415)

* initial pass at changing urls and anchors

* update api.asciidoc

* upate a few more anchor tags

* upate a few more anchor tags

* update data view api docs

* Update delete.asciidoc

* Update default-get.asciidoc

* add redirects

* fix redirects

* remove duplicate redirect

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 1, 2021
…) (#120097)

* initial pass at changing urls and anchors

* update api.asciidoc

* upate a few more anchor tags

* upate a few more anchor tags

* update data view api docs

* Update delete.asciidoc

* Update default-get.asciidoc

* add redirects

* fix redirects

* remove duplicate redirect

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Matthew Kime <matt@mattki.me>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…ic#119415)

* initial pass at changing urls and anchors

* update api.asciidoc

* upate a few more anchor tags

* upate a few more anchor tags

* update data view api docs

* Update delete.asciidoc

* Update default-get.asciidoc

* add redirects

* fix redirects

* remove duplicate redirect

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants