Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for superuser not having write access #123337

Merged
merged 16 commits into from
Jan 24, 2022

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jan 19, 2022

Changes in response to elastic/elasticsearch#81400

Some tests needed to be skipped as the data archive was not supported:

Likely root cause: org.elasticsearch.gateway.CorruptStateException: Format version is not supported. Upgrading to [8.1.0] is only supported from version [7.17.0]

For anyone testing this, or investigating the skipped tests. It's likely that the failures are only when running against the current version of Elasticsearch. I did this at #123338. If you would like to do this locally, you can set KBN_ES_SNAPSHOT_USE_UNVERIFIED=true. More details can be found in the docs.

TODO:

  • Create issues for any skipped tests after merging.

Tyler Smalley and others added 7 commits January 18, 2022 22:02
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

Tyler Smalley added 6 commits January 20, 2022 23:33
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the superuser-read branch 2 times, most recently from b4d2eb1 to ea32b0f Compare January 22, 2022 22:48
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 23, 2022
@tylersmalley tylersmalley marked this pull request as ready for review January 23, 2022 00:13
@tylersmalley tylersmalley requested review from a team as code owners January 23, 2022 00:13
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 24, 2022
@tylersmalley
Copy link
Contributor Author

All passed - for some reason, some were not reported.

@tylersmalley tylersmalley merged commit 23739f5 into elastic:main Jan 24, 2022
@tylersmalley tylersmalley deleted the superuser-read branch January 24, 2022 17:39
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.0 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 123337

Questions ?

Please refer to the Backport tool documentation

tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jan 24, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

# Conflicts:
#	src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts
tylersmalley pushed a commit that referenced this pull request Jan 24, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

# Conflicts:
#	src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit to jbudz/kibana that referenced this pull request Jan 27, 2022
Testing against 8.0 requires system index write access introduced in
elastic#123337.  This adds a temporary
skip while the backport is in progress.
jbudz pushed a commit to jbudz/kibana that referenced this pull request Jan 27, 2022
…ic#123639)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit that referenced this pull request Jan 27, 2022
…123961)

Testing against 8.0 requires system index write access introduced in
#123337.  This adds a temporary
skip while the backport is in progress.
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 3, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants