-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for superuser not having write access #123337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@elasticmachine merge upstream |
tylersmalley
force-pushed
the
superuser-read
branch
from
January 21, 2022 00:20
db1e84c
to
81c804f
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
superuser-read
branch
2 times, most recently
from
January 22, 2022 22:48
b4d2eb1
to
ea32b0f
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
superuser-read
branch
from
January 22, 2022 22:51
774c98b
to
3f0c1d4
Compare
tylersmalley
added
Team:Operations
Team label for Operations Team
v8.0.0
v8.1.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 23, 2022
jbudz
approved these changes
Jan 24, 2022
tsullivan
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tylersmalley
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Jan 24, 2022
All passed - for some reason, some were not reported. |
💔 All backports failed
How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 24, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 23739f5) # Conflicts: # src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts
tylersmalley
pushed a commit
that referenced
this pull request
Jan 24, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 23739f5) # Conflicts: # src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jan 27, 2022
Testing against 8.0 requires system index write access introduced in elastic#123337. This adds a temporary skip while the backport is in progress.
jbudz
pushed a commit
to jbudz/kibana
that referenced
this pull request
Jan 27, 2022
…ic#123639) Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 23739f5) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Jan 28, 2022
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:Operations
Team label for Operations Team
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in response to elastic/elasticsearch#81400
Some tests needed to be skipped as the data archive was not supported:
For anyone testing this, or investigating the skipped tests. It's likely that the failures are only when running against the current version of Elasticsearch. I did this at #123338. If you would like to do this locally, you can set
KBN_ES_SNAPSHOT_USE_UNVERIFIED=true
. More details can be found in the docs.TODO: