Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/es] add support for --ready-timeout #126217

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 23, 2022

We've been getting reports of kbn/es causing problems for people who are using custom data directories. It seems this is caused by two things:

  1. the _autoRetry function in the NativeRealm class wasn't slowing down for subsequent retry attempts and instead always retrying after 1 second, meaning that we would exhaust our 10 retries for cluster state after about 10 seconds.
  2. the timeout can't be customized, and wasn't explitict before, but was a side effect of how many attempts were allowed.

To fix this I moved the ready check out of NativeRealm (didn't feel like the right place for it, and I had new config to plumb), updated it to respect a timeout, and then added readyTimeout/--ready-timeout and skipReadyCheck/--skip-ready-check options.

@spalger spalger force-pushed the fix/kbn-es/add-startup-timeout branch 2 times, most recently from 27715d4 to 9120332 Compare February 23, 2022 18:22
@spalger spalger force-pushed the fix/kbn-es/add-startup-timeout branch from 9120332 to 7179bfa Compare February 23, 2022 18:24
@spalger spalger added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.1 v8.0.0 v8.1.0 v8.2.0 labels Feb 23, 2022
@spalger spalger marked this pull request as ready for review February 23, 2022 19:49
@spalger spalger requested a review from a team as a code owner February 23, 2022 19:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) February 24, 2022 21:21
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit a16c20b into elastic:main Feb 24, 2022
@spalger spalger deleted the fix/kbn-es/add-startup-timeout branch February 24, 2022 22:44
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2022
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0
8.1
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Support for superuser not having write access (#123337)

How to fix

Re-run the backport manually:

node scripts/backport --pr 126217

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 25, 2022
(cherry picked from commit a16c20b)

Co-authored-by: Spencer <spencer@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 25, 2022
(cherry picked from commit a16c20b)

Co-authored-by: Spencer <spencer@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.1 v8.0.0 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants