Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified observability] Use the new dataViews service in the observability plugin #124952

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 8, 2022

Summary

Closes #124169

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.2.0 labels Feb 8, 2022
@afgomez afgomez requested review from a team as code owners February 8, 2022 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afgomez
Copy link
Contributor Author

afgomez commented Feb 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 327 328 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 393.0KB 393.0KB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 85.0KB 85.0KB +6.0B
Unknown metric groups

API count

id before after diff
observability 330 331 +1

References to deprecated APIs

id before after diff
observability 132 119 -13

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit e298474 into elastic:main Feb 10, 2022
@afgomez afgomez deleted the 124169-data-views-service branch February 10, 2022 15:53
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 14, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124952 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124952 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to DataViews service from IndexPattern service
8 participants