-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Avoid breaking setup when compatible package is not available in registry #125525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
commented
Feb 14, 2022
joshdover
force-pushed
the
fleet/fix-125409
branch
from
February 15, 2022 13:27
b0a7317
to
f296de1
Compare
joshdover
added
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:fix
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.0.1
v8.1.0
v8.2.0
labels
Feb 15, 2022
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2022
… in registry (elastic#125525) (cherry picked from commit 928638e)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2022
… in registry (elastic#125525) (cherry picked from commit 928638e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 16, 2022
…ilable in registry (#125525) (#125672) * [Fleet] Avoid breaking setup when compatible package is not available in registry (#125525) (cherry picked from commit 928638e) * [Fleet] Use registry version check on main (#125495) * [Fleet] Get package info should not store the whole package (#123509) Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
1 task
kibanamachine
added a commit
that referenced
this pull request
Feb 16, 2022
…ilable in registry (#125525) (#125671) * [Fleet] Avoid breaking setup when compatible package is not available in registry (#125525) (cherry picked from commit 928638e) * [Fleet] Get package info should not store the whole package (#123509) Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:fix
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.0.1
v8.1.0
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #125409
This changes our package fetching logic to avoid throwing errors when a (compatible) package is no longer available in the registry, but the cluster already has a version of the package installed.
It also introduces a new
ignore_constraints
parameter on the install package API which enables writing an automated test for this scenario easily, but may be useful in other scenarios as well.You can test this with the following:
xpack.fleet.developer.disableRegistryVersionCheck: true
cyberark
package and create an integration policy for itxpack.fleet.developer.disableRegistryVersionCheck
and restart KibanaChecklist
Delete any items that are not applicable to this PR.