Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Use package policy version to determine managed policy upgrades #125788

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

joshdover
Copy link
Contributor

Summary

Similar to #125525, this handles another scenario where a package version may no longer be available in the registry. In this case, a prerelease version of a managed package can cause the auto-upgrades for managed package policies to fail during Fleet setup due to the previous prerelease version not being present in the registry or installed in ES any longer.

I changed the decision logic for deciding when to upgrade a managed package policy by removing the fetch of the package from ES storage or the registry which seemed unnecessary since the required information is already present in fetching the installed version of the package and the version information on the package policy itself.

Checklist

Delete any items that are not applicable to this PR.

@joshdover joshdover added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0 v8.0.1 labels Feb 16, 2022
@joshdover joshdover requested a review from kpollich February 16, 2022 13:41
@joshdover joshdover requested a review from a team as a code owner February 16, 2022 13:41
@joshdover joshdover self-assigned this Feb 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 16, 2022
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #1 / Execution context Browser apps dashboard app propagates context for Vertical bar visualization

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @joshdover

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2022
kibanamachine added a commit that referenced this pull request Feb 16, 2022
…es (#125788) (#125826)

(cherry picked from commit 3dd2d75)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 17, 2022
…es (#125788) (#125825)

(cherry picked from commit 3dd2d75)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants