[XY] Support vis_dimension type for accessors
#128063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to chart_expressions-xy
# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx
…to chart_expressions-xy
# Conflicts: # x-pack/test/functional/apps/lens/show_underlying_data.ts
…art_expressions-xy-support-visdimension-type
…y-support-visdimension-type
VladLasitsa
added
Feature:XYAxis
mbondyra
reviewed
Mar 29, 2022
src/plugins/chart_expressions/expression_xy/public/components/reference_lines.tsx
Show resolved
Hide resolved
…pressions-xy-support-visdimension-type # Conflicts: # packages/kbn-optimizer/limits.yml # src/plugins/chart_expressions/expression_xy/public/components/reference_lines.tsx
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Kuznietsov
reviewed
Mar 31, 2022
| @@ -23,7 +27,9 @@ export const getAppliedTimeRange = (layers: DataLayerArgs[], data: LensMultiTabl | |||
| return Object.entries(data.tables) | |||
| .map(([tableId, table]) => { | |||
| const layer = layers.find((l) => l.layerId === tableId); | |||
| const xColumn = table.columns.find((col) => col.id === layer?.xAccessor); | |||
| const xColumn = layer?.xAccessor | |||
| ? getColumnByAccessor(layer?.xAccessor, table.columns) | |||
There was a problem hiding this comment.
Nit: you can use layer.xAccessor here.
| .flatMap((layer) => | ||
| data.tables[layer.layerId].rows.map((row) => row[layer.xAccessor!].valueOf() as number) | ||
| ) | ||
| .flatMap((layer) => { |
There was a problem hiding this comment.
Nit: instead of using as number, you could use flatMap<number> here.
PS: I know, you are not the author of this code.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Kuznietsov
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Found such a weird bug. Could you, please, address it.
Screen.Recording.2022-04-01.at.16.59.49.mov
Expression:
kibana
| lens_merge_tables layerIds="f6ed53d9-fc5d-4051-85c1-f6a3eba00726"
layerIds="8975a4f4-46c0-4481-9c91-1c036feb489d"
tables={esaggs index={indexPatternLoad id="90943e30-9a47-11e8-b64d-95841ca0b247"} aggs={aggDateHistogram id="0" enabled=true schema="segment" field="@timestamp" useNormalizedEsInterval=true interval="auto" drop_partials=false min_doc_count=0 extended_bounds={extendedBounds} extendToTimeRange=true} aggs={aggAvg id="1" enabled=true schema="metric" field="bytes"} metricsAtAllLevels=false partialRows=false timeFields="@timestamp" | lens_rename_columns idMap="{\"col-0-0\":{\"label\":\"@timestamp\",\"dataType\":\"date\",\"operationType\":\"date_histogram\",\"sourceField\":\"@timestamp\",\"isBucketed\":true,\"scale\":\"interval\",\"params\":{\"interval\":\"auto\",\"includeEmptyRows\":true,\"dropPartials\":false},\"id\":\"c2305c94-6b9e-4e8d-a46a-c10b79c76f01\"},\"col-1-1\":{\"label\":\"Average of bytes\",\"dataType\":\"number\",\"operationType\":\"average\",\"sourceField\":\"bytes\",\"isBucketed\":false,\"scale\":\"ratio\",\"params\":{\"emptyAsNull\":true},\"id\":\"4bca57f0-7d03-4fb3-b7a7-e1b6f418eac9\"}}"}
tables={createTable rowCount=1 | mathColumn id="26f34410-a1f5-42eb-bc10-6dc4bc893ac4" name="Static value: 7299" expression="7299"}
| xyVis title="" description="" xTitle="" yTitle="" yRightTitle="" legend={legendConfig isVisible=true position="right" shouldTruncate=true} fittingFunction="None" endValue="None" emphasizeFitting=false curveType="LINEAR" fillOpacity=0.3 yLeftExtent={axisExtentConfig mode="full"} yRightExtent={axisExtentConfig mode="full"}
axisTitlesVisibilitySettings={axisTitlesVisibilityConfig x=true yLeft=true yRight=true} tickLabelsVisibilitySettings={tickLabelsConfig x=true yLeft=true yRight=true} gridlinesVisibilitySettings={gridlinesConfig x=true yLeft=true yRight=true} labelsOrientation={labelsOrientationConfig x=0 yLeft=0 yRight=0} valueLabels="hide" hideEndzones=false valuesInLegend=false
layers={dataLayer layerId="f6ed53d9-fc5d-4051-85c1-f6a3eba00726" hide=false xAccessor="c2305c94-6b9e-4e8d-a46a-c10b79c76f01" yScaleType="linear" xScaleType="time" isHistogram=true seriesType="bar_stacked" accessors={visdimension "4bca57f0-7d03-4fb3-b7a7-e1b6f418eac9"} columnToLabel="{\"4bca57f0-7d03-4fb3-b7a7-e1b6f418eac9\":\"Average of bytes\"}" palette={system_palette name="default"}}
layers={referenceLineLayer layerId="8975a4f4-46c0-4481-9c91-1c036feb489d" yConfig={yConfig forAccessor="26f34410-a1f5-42eb-bc10-6dc4bc893ac4" axisMode="left" color="#69707d" lineStyle="solid" lineWidth=1 fill="none" iconPosition="auto" textVisibility=false} accessors={visdimension "26f34410-a1f5-42eb-bc10-6dc4bc893ac4"} columnToLabel="{\"26f34410-a1f5-42eb-bc10-6dc4bc893ac4\":\"Static value: 7299\"}"}
The same about forAccessor:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes part of #127115
Summary
Added full support of visdimension at fields:
splitAccessor,accessors,xAccessor,forAccessor