Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Expression unification #127115

Closed
31 tasks done
Kuznietsov opened this issue Mar 8, 2022 · 5 comments
Closed
31 tasks done

[XY] Expression unification #127115

Kuznietsov opened this issue Mar 8, 2022 · 5 comments
Assignees
Labels
Feature:Canvas Feature:Lens Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort NeededFor:VisEditors release_note:feature Makes this part of the condensed release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Kuznietsov
Copy link
Contributor

Kuznietsov commented Mar 8, 2022

Plan

  • Move xy function and renderer to the separate plugin (chart_expressions/expression_xy) from Lens. Register expression functions on the server and client sides - [XY] Expression chart. #127150 (author: @Kunzetsov)
  • Write down the issue with the comparison of xy_vis and lens_xy_chart configuration possibilities with highlighting missing features - [XY] Adapt for xyVis. #127712 (author: @VladLasitsa)

Additional types for the existing arguments


Global features, required for using xy in Lens/VisTypes/Canvas.


Missing features, required at VisEditors xy implementation


Final steps of the plan


cc @crob611, @stratoula, @flash1293, @alexwizp, @VladLasitsa


co-author: @VladLasitsa.

@Kuznietsov Kuznietsov added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) loe:x-large Extra Large Level of Effort Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. NeededFor:Canvas Feature:Canvas release_note:feature Makes this part of the condensed release notes NeededFor:VisEditors labels Mar 8, 2022
@Kuznietsov Kuznietsov self-assigned this Mar 8, 2022
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Mar 8, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 8, 2022
@flash1293
Copy link
Contributor

Add support of palette expression function instead of string

Lens should support palette expression function already: Add support of palette expression function instead of string

Check if filters are applied to the expression functions, executed at the table arguments of the layers.

What exactly is this referring to?

@Kuznietsov
Copy link
Contributor Author

Kuznietsov commented Mar 8, 2022

@flash1293, there is such expression chain:

kibana
| selectFilter ...
| removeFilter ...
| esaggs ...
...

These filters are applied to the datasource expressions, like esaggs. If we are creating separate fetches, adding tables to the layers, we should check if these filters are applied to the execution context, or we will have to duplicate expressions with filters on every layer table fetch.

I don't remember the code of those expressions, so, need to investigate it when the time will come and propose the useful solution in case of the troubles.

@flash1293
Copy link
Contributor

I see, for Lens this wouldn't be relevant because we aren't manipulating filters this way (it's just the kibana context, then esaggs). I see it being relevant for Canvas.

@Kuznietsov
Copy link
Contributor Author

Yes. And this ability is provided by the data plugin and we were moving the canvas in this direction not so long time ago. As I understand, a lot of parts of Kibana will rely on it in the future, as the only way of manipulating filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Feature:Lens Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort NeededFor:VisEditors release_note:feature Makes this part of the condensed release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants