Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] Add interval arg #128157

Closed
wants to merge 62 commits into from
Closed

[XY] Add interval arg #128157

wants to merge 62 commits into from

Conversation

VladLasitsa
Copy link
Contributor

Completes part of #127115

Summary

Added possibility to override the x-axis interval.

Kuznietsov and others added 30 commits March 8, 2022 16:08
@Kuznietsov
added xy plugin.
9388bba
@kibanamachine
Merge branch 'main' into chart_expressions-xy
8df9659
@Kuznietsov
Added expressionXY limits.
ab72728
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
5747322 
…to chart_expressions-xy
@Kuznietsov
Added xy expression functions to the expression_xy plugin.
b4ee9c1
@Kuznietsov
Moved xy to a separate plugin.
400845d
@Kuznietsov
Small refactoring.
b2090f3
@Kuznietsov
Fixed types.
33a06fa
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
d94fa4f 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.tsx
@Kuznietsov
Fixed import of scss.
663e093
@Kuznietsov
Fixed imports.
cbffe77
@Kuznietsov
Added required plugins.
389f933
@Kuznietsov
Fixed import
90aa97a
@Kuznietsov
Fixed types.
1d3a264
@Kuznietsov
Changed expression names.
a78d45d
@Kuznietsov
Fixed bugs, caused by the refactoring process.
35cab91
@kibanamachine
Merge branch 'main' into chart_expressions-xy
847b3c4
@Kuznietsov
Fixed lens snapshots.
ed7f8ea
@Kuznietsov
Removed new line.
b6daa5d
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
bda6524 
…to chart_expressions-xy
@Kuznietsov
Fixed xy_chart tests.
c8d40fe
@Kuznietsov
Added lazy loading for xy chart.
5fed60c
@Kuznietsov
Fixed xy chart test.
dc195b2
@Kuznietsov
Fixed broken chart selectors.
d39681f
@Kuznietsov
Fixed dashboard tests.
b901d68
@Kuznietsov
dashboard test fixed.
d327dfe
@Kuznietsov
Fixed heatmap vis.
b500961
@Kuznietsov
Smokescreen test fixed.
7a25b74
@Kuznietsov
more fixes.
0004794
@Kuznietsov
async dashboard tests fixed.
fc8c0b3
Kuznietsov and others added 26 commits March 16, 2022 17:11
@Kuznietsov
Fixed some more test at ml.
7cb4db4
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
98e8661 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_chart.ts
#	src/plugins/chart_expressions/expression_xy/public/components/reference_lines.tsx
#	x-pack/plugins/lens/public/xy_visualization/expression.tsx
#	x-pack/plugins/lens/public/xy_visualization/reference_line_helpers.tsx
#	x-pack/plugins/lens/public/xy_visualization/state_helpers.ts
#	x-pack/plugins/lens/public/xy_visualization/to_expression.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.test.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.tsx
#	x-pack/plugins/lens/public/xy_visualization/visualization_helpers.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/color_picker.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/dimension_editor.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/reference_line_panel.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/line_style_settings.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/marker_decoration_settings.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/xy_config_panel.test.tsx
@Kuznietsov
Fixed types and imports
5ea9cc5
@Kuznietsov
Fixed handlers.inspectorAdapters.tables.logDatatable
4f72658
@Kuznietsov
Fixed logDatatable
ee4ec20
@Kuznietsov
Translations fixed.
e72005c
@Kuznietsov
Fixed "Visualize App ... cleans filters and query" test.
902972d 
cleans filters and query
@Kuznietsov
Fixed "lens disable auto-apply tests" test.
05b0f8d
@Kuznietsov
Updated dashboard tests.
cae1e75
@Kuznietsov
Fixed translations.
00c7e28
@Kuznietsov
Expression tests fixed.
0ad3793
@Kuznietsov
Cleaned up expression_xy.
2fbe81f
@Kuznietsov
cleaned up lens xy_visualization.
e9c497f
@Kuznietsov
fixed more tests.
ea299ec
@Kuznietsov
Fix of tsvb.
9ea2cbb
@Kuznietsov
Fixed more tests.
46edc6b
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
672885c 
# Conflicts:
#	x-pack/plugins/lens/public/shared_components/axis_title_settings.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/axis_settings_popover.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
f109200
@Kuznietsov
Fixed xy chart limits.
498b34e
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
eeefc8b 
…to chart_expressions-xy
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
e00f089 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
#	x-pack/plugins/lens/public/index.ts
@Kuznietsov
Fixed new tests.
4996ea6
@Kuznietsov
Fixed types.
97bb678
@kibanamachine
Merge branch 'main' into chart_expressions-xy
f91c8d5
@kibanamachine
Merge branch 'main' into chart_expressions-xy
0b6db50
@VladLasitsa
Add interval arg
e557ac6
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionXY - 61 +61
lens 757 730 -27
total +34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionXY - 446 +446
lens 353 423 +70
total +516

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY - 31.9KB +31.9KB
lens 1.1MB 1.1MB -20.7KB
total +11.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 42 29 -13

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY - 25.9KB +25.9KB
lens 43.2KB 29.0KB -14.2KB
total +11.7KB
Unknown metric groups

API count

id before after diff
expressionXY - 456 +456
lens 426 496 +70
total +526

async chunk count

id before after diff
expressionXY - 1 +1

ESLint disabled line counts

id before after diff
lens 32 29 -3

Total ESLint disabled count

id before after diff
lens 34 31 -3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa mentioned this pull request Mar 22, 2022
Closed
31 tasks
@VladLasitsa
Copy link
Contributor Author

Created another PR for that #128726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VladLasitsa @kibana-ci @Kuznietsov @kibanamachine