Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] Mark size configuration. #130361

Merged
merged 192 commits into from
May 19, 2022
Merged

[XY] Mark size configuration. #130361

merged 192 commits into from
May 19, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Apr 15, 2022 •
edited
Loading

Summary

Completes part of #127115
Added markSizeAccessor to the xyVis and extendedDataLayer expressions.
Added markSizeRatio to the xyVis and layeredXyVis expressions.

markSizeAccessor is specified

Screenshot 2022-05-17 at 17 38 12

markSizeAccessor visdimension with specific format

Screenshot 2022-05-17 at 17 42 11

markSizeRatio is specified

Screenshot 2022-05-17 at 17 39 09

markSizeAccessor is specified for the series, different from area* and line charts.

Screenshot 2022-05-17 at 17 39 39

markSizeAccessor is pointing to non-existent column

Screenshot 2022-05-17 at 17 40 03

markSizeRatio is greater then 100 and lower than 0

Screenshot 2022-05-17 at 17 40 34

Screenshot 2022-05-17 at 17 40 53

pointseries

Screenshot 2022-05-18 at 12 31 37

Kuznietsov and others added 30 commits March 8, 2022 16:08
@Kuznietsov
added xy plugin.
9388bba
@kibanamachine
Merge branch 'main' into chart_expressions-xy
8df9659
@Kuznietsov
Added expressionXY limits.
ab72728
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
5747322 
…to chart_expressions-xy
@Kuznietsov
Added xy expression functions to the expression_xy plugin.
b4ee9c1
@Kuznietsov
Moved xy to a separate plugin.
400845d
@Kuznietsov
Small refactoring.
b2090f3
@Kuznietsov
Fixed types.
33a06fa
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
d94fa4f 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.tsx
@Kuznietsov
Fixed import of scss.
663e093
@Kuznietsov
Fixed imports.
cbffe77
@Kuznietsov
Added required plugins.
389f933
@Kuznietsov
Fixed import
90aa97a
@Kuznietsov
Fixed types.
1d3a264
@Kuznietsov
Changed expression names.
a78d45d
@Kuznietsov
Fixed bugs, caused by the refactoring process.
35cab91
@kibanamachine
Merge branch 'main' into chart_expressions-xy
847b3c4
@Kuznietsov
Fixed lens snapshots.
ed7f8ea
@Kuznietsov
Removed new line.
b6daa5d
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
bda6524 
…to chart_expressions-xy
@Kuznietsov
Fixed xy_chart tests.
c8d40fe
@Kuznietsov
Added lazy loading for xy chart.
5fed60c
@Kuznietsov
Fixed xy chart test.
dc195b2
@Kuznietsov
Fixed broken chart selectors.
d39681f
@Kuznietsov
Fixed dashboard tests.
b901d68
@Kuznietsov
dashboard test fixed.
d327dfe
@Kuznietsov
Fixed heatmap vis.
b500961
@Kuznietsov
Smokescreen test fixed.
7a25b74
@Kuznietsov
more fixes.
0004794
@Kuznietsov
async dashboard tests fixed.
fc8c0b3
@Kuznietsov Kuznietsov added the WIP Work in progress label May 6, 2022
@Kuznietsov Kuznietsov mentioned this pull request May 11, 2022
Merged
Kuznietsov added 2 commits May 17, 2022 15:59
@Kuznietsov
Merge branch 'main' into chart_expressions-xy-mark_size_accessor
a971d9a 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/__snapshots__/xy_vis.test.ts.snap
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/common_data_layer_args.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/common_xy_args.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer.test.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/extended_data_layer_fn.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis_fn.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.test.ts
#	src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx
#	src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
#	src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx
@Kuznietsov
Added markSizeAccessor to extendedDataLayer and xyVis.
7bd31f3
VladLasitsa
VladLasitsa reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VladLasitsa VladLasitsa self-requested a review May 17, 2022 13:58
VladLasitsa
VladLasitsa approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VladLasitsa VladLasitsa marked this pull request as ready for review May 17, 2022 14:00
@VladLasitsa VladLasitsa requested a review from a team as a code owner May 17, 2022 14:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-vis-editors, could you, please, review this PR? Thanks )

flash1293
flash1293 reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointseries has a size argument - I think we should map it to the markSizeAccessor by default, just like x and y.

Otherwise looks good to me (see comment about default marksize ratio)

src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx Outdated Show resolved Hide resolved
@Kuznietsov
Copy link
Contributor Author

@flash1293, added the size support from the pointseries and changed the default. Could you, please, review it again? Thanks.

@Kuznietsov Kuznietsov requested a review from flash1293 May 18, 2022 11:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionXY 126 128 +2
lens 455 457 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 66.0KB 73.9KB +7.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY 29.5KB 30.0KB +516.0B
Unknown metric groups

API count

id before after diff
expressionXY 136 138 +2
lens 530 532 +2
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

flash1293
flash1293 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected

@Kuznietsov Kuznietsov merged commit dd8bd6f into elastic:main May 19, 2022
@Kuznietsov Kuznietsov removed the WIP Work in progress label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@flash1293 flash1293 flash1293 approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:VisEditors release_note:feature Makes this part of the condensed release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kuznietsov @elasticmachine @kibana-ci @flash1293 @VladLasitsa @kibanamachine