[Osquery] Refactor ECS editor field #130582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
force-pushed
the
chore/ecs-form-refactor
branch
from
b0c0cd3 to
58a180d
Compare
patrykkopycinski
added
release_note:skip
|
Pinging @elastic/security-asset-management (Team:Asset Management) |
|
@elasticmachine merge upstream |
tomsonpl
approved these changes
Apr 27, 2022
| grouper.setTotalAgents(totalNumAgents); | ||
| grouper.updateGroup(AGENT_GROUP_KEY.Platform, groups.platforms); | ||
| grouper.updateGroup(AGENT_GROUP_KEY.Policy, groups.policies); | ||
| grouper.setTotalAgents(agentGroupsData?.totalCount); |
There was a problem hiding this comment.
Are you sure that we need optional chaining? There is a check for agentGroupsData in line 154
| import { SavedQueriesDropdown } from '../../saved_queries/saved_queries_dropdown'; | ||
|
|
||
| const FORM_ID = 'liveQueryForm'; | ||
|
|
||
| const StyledEuiAccordion = styled(EuiAccordion)` | ||
| ${({ isDisabled }: { isDisabled: boolean }) => isDisabled && 'display: none;'} | ||
| ${({ isDisabled }: { isDisabled?: boolean }) => isDisabled && 'display: none;'} |
There was a problem hiding this comment.
what would you say about typing isDisabled as 'isDisabled?: true' ? Since it may not exist, the value we want is true, never false.
x-pack/plugins/osquery/public/saved_queries/form/use_saved_query_form.tsx
Show resolved
Hide resolved
miltonhultgren
approved these changes
Apr 27, 2022
…refactor # Conflicts: # x-pack/plugins/osquery/cypress/integration/all/live_query.spec.ts # x-pack/plugins/osquery/cypress/tasks/live_query.ts # x-pack/plugins/osquery/public/live_queries/form/index.tsx # x-pack/plugins/osquery/public/live_queries/index.tsx # x-pack/plugins/osquery/public/results/results_table.tsx # x-pack/plugins/osquery/public/routes/saved_queries/edit/tabs.tsx # x-pack/plugins/osquery/public/saved_queries/saved_query_flyout.tsx # x-pack/plugins/osquery/public/shared_components/osquery_action/index.tsx
💛 Build succeeded, but was flakyMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored ECS editor field to leverage updated
UseArrayfield andform.updateFieldValues()from:This PR is also removing steps from the Live Query form