Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Fix ECS editor field array value #132786

Merged
merged 24 commits into from
May 25, 2022
Merged

[Osquery] Fix ECS editor field array value #132786

merged 24 commits into from
May 25, 2022

Conversation

patrykkopycinski
Copy link
Contributor

Follow up for #130582

@patrykkopycinski patrykkopycinski self-assigned this May 24, 2022
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

tomsonpl
tomsonpl approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patrykkopycinski patrykkopycinski marked this pull request as ready for review May 24, 2022 17:07
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 24, 2022 17:07
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature v8.3.0 labels May 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

tomsonpl
tomsonpl approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the types can be added later on:) Great job, thanks!

x-pack/plugins/osquery/public/live_queries/form/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/osquery/public/live_queries/form/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/osquery/server/routes/saved_query/utils.ts Show resolved Hide resolved
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

james-elastic
james-elastic approved these changes May 24, 2022
View reviewed changes
Copy link

@james-elastic james-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 24, 2022 19:38
This was referenced May 24, 2022
Closed
Closed
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski enabled auto-merge (squash) May 24, 2022 21:59
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 272d9be into elastic:main May 25, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / discover app discover data grid doc table should show popover with expanded cell content by click on expand button

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 264 263 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB -1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski deleted the fix/osquery-ecs-field branch May 25, 2022 14:56
@patrykkopycinski patrykkopycinski added auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 and removed backport:skip This commit does not require backporting v8.3.0 labels Jun 9, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 9, 2022
@patrykkopycinski patrykkopycinski added v8.3.0 and removed backport:skip This commit does not require backporting labels Jun 9, 2022
@patrykkopycinski patrykkopycinski mentioned this pull request Jun 9, 2022
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jun 9, 2022
@patrykkopycinski
[Osquery] Fix ECS editor field array value (elastic#132786)
2470017 
(cherry picked from commit 272d9be)
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.4 The branch "8.4" is invalid or doesn't exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 132786

Questions ?

Please refer to the Backport tool documentation

patrykkopycinski added a commit that referenced this pull request Jun 9, 2022
@patrykkopycinski
[8.3] [Osquery] Fix ECS editor field array value (#132786) (#134054)
0b6a033 
* [Osquery] Fix ECS editor field array value (#132786)

(cherry picked from commit 272d9be)

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-elastic james-elastic james-elastic approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@patrykkopycinski @elasticmachine @brianseeders @kibana-ci @kibanamachine @andrew-goldstein @tomsonpl @james-elastic