[APM] Set a valid service_name for python APM onboarding #131959
Conversation
|
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
LGTM. But you'll need to fix some unit tests like: https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/tutorial/config_agent/commands/get_commands.test.ts#L184
|
@elasticmachine merge upstream |
|
@trentm @stuartnelson3 I took the liberty of adding a SERVICE_NAME to the node/go configuration samples. If that change doesn't make sense for either of your agents, please tell me! |
x-pack/plugins/apm/public/tutorial/config_agent/commands/node.ts
Outdated
Show resolved
Hide resolved
|
@trentm @stuartnelson3 I'm reverting those changes, keep things simple. I'm guessing go deals with the empty string similar to Node. If not, you know where you can change it! :) |
This reverts commit 5747d80.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
) * Set a valid SERVICE_NAME for python APM onboarding * Fix unit tests * Update the examples for node and golang * Revert "Update the examples for node and golang" This reverts commit 5747d80. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
A user noticed that we were recommending an empty string for
SERVICE_NAMEin our python APM onboarding. This is invalid and will result in no data showing up in the APM app.I have fixed the sample config to include a generic service name.
Checklist
No items were applicable to this change.
For maintainers