Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out SERVICE_NAME for django/flask onboarding #132364

Merged
merged 1 commit into from
May 17, 2022
Merged

Comment out SERVICE_NAME for django/flask onboarding #132364

merged 1 commit into from
May 17, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented May 17, 2022

Summary

After some discussion, we realized that #131959 would probably be better if we just commented out the service_name, which would use the configured default and encourage better behavior (setting a useful SERVICE_NAME) from the user.

Checklist

No items were applicable to this change.

For maintainers

@basepi basepi requested a review from a team as a code owner May 17, 2022 18:48
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +12.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 17, 2022
cauemarcondes
cauemarcondes approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@basepi basepi merged commit f9548d7 into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@basepi @elasticmachine @kibana-ci @cauemarcondes @kibanamachine