Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM]Adding tech preview on Span Links feature #132280

Merged
merged 2 commits into from
May 17, 2022
Merged

[APM]Adding tech preview on Span Links feature #132280

merged 2 commits into from
May 17, 2022

Conversation

cauemarcondes
Copy link
Contributor

Screen Shot 2022-05-16 at 3 26 54 PM

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 16, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner May 16, 2022 19:28
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from boriskirov May 16, 2022 19:28
gbamparop
gbamparop approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/apm/public/components/shared/span_links/span_links_tab_content.tsx Outdated Show resolved Hide resolved
@cauemarcondes cauemarcondes enabled auto-merge (squash) May 17, 2022 14:53
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +203.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 11b9c29 into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
@kpatticha kpatticha mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop approved these changes

@boriskirov boriskirov boriskirov approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cauemarcondes @elasticmachine @kibana-ci @gbamparop @boriskirov @kibanamachine