Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Adding tech preview on Alert Tab feature #136615

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jul 19, 2022

Screenshot 2022-07-19 at 14 34 08

Screenshot 2022-07-19 at 14 33 57

Follows the same design as span links tech preview - #132280

@kpatticha kpatticha requested a review from a team as a code owner July 19, 2022 10:40
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kpatticha kpatticha requested a review from boriskirov July 19, 2022 10:48
@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 19, 2022
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

defaultMessage: 'Alerts',
}),
label: (
<EuiFlexGroup direction="row" gutterSize="xs">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<EuiFlexGroup direction="row" gutterSize="xs">
<EuiFlexGroup gutterSize="xs">

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +168.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit f30cfc1 into elastic:main Jul 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants