Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out SERVICE_NAME for django/flask onboarding #132364

Merged
merged 1 commit into from
May 17, 2022
Merged

Comment out SERVICE_NAME for django/flask onboarding #132364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/tutorial/config_agent/commands/django.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ELASTIC_APM = {
defaultMessage: 'a-z, A-Z, 0-9, -, _, and space',
}
)}
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# ${i18n.translate(
'xpack.apm.tutorial.djangoClient.configure.commands.useIfApmServerRequiresTokenComment',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/tutorial/config_agent/commands/flask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ app.config['ELASTIC_APM'] = {
defaultMessage: 'a-z, A-Z, 0-9, -, _, and space',
}
)}
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# ${i18n.translate(
'xpack.apm.tutorial.flaskClient.configure.commands.useIfApmServerRequiresTokenComment',
Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugins/apm/public/tutorial/config_agent/commands/get_commands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ describe('getCommands', () => {
ELASTIC_APM = {
# Set the required service name. Allowed characters:
# a-z, A-Z, 0-9, -, _, and space
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# Use if APM Server requires a secret token
'SECRET_TOKEN': '',
Expand Down Expand Up @@ -219,7 +219,7 @@ describe('getCommands', () => {
ELASTIC_APM = {
# Set the required service name. Allowed characters:
# a-z, A-Z, 0-9, -, _, and space
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# Use if APM Server requires a secret token
'SECRET_TOKEN': 'foobar',
Expand Down Expand Up @@ -257,7 +257,7 @@ describe('getCommands', () => {
app.config['ELASTIC_APM'] = {
# Set the required service name. Allowed characters:
# a-z, A-Z, 0-9, -, _, and space
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# Use if APM Server requires a secret token
'SECRET_TOKEN': '',
Expand Down Expand Up @@ -292,7 +292,7 @@ describe('getCommands', () => {
app.config['ELASTIC_APM'] = {
# Set the required service name. Allowed characters:
# a-z, A-Z, 0-9, -, _, and space
'SERVICE_NAME': 'my_python_service',
#'SERVICE_NAME': 'unknown-python-service',

# Use if APM Server requires a secret token
'SECRET_TOKEN': 'foobar',
Expand Down