[Infrastructure UI][Rules] Change bucket_scripts to use params for thresholds

[simianhacker]

Summary

This PR fixes #133210 by changing the Metric Threshold Rule and Inventory Threshold Rule to use params for the thresholds instead of hard coding them.

Before:

"shouldTrigger": {
  "bucket_script": {
    "buckets_path": {
      "value": "rx"
    },
      "script": "params.value > 107374182400 ? 1 : 0"
  }
}

After:

"shouldTrigger": {
  "bucket_script": {
    "buckets_path": {
      "value": "rx"
    },
      "script": {
        "source":"params.value > params.threshold ? 1 : 0",
        "params": {
          "threshold": 107374182400
        }
      }
  }
}

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

Note to Reviewers

I'm aware that there is duplicate code between these two rules, specifically the create_condition_script.ts. When these two rules were written, they were developed simultaneously; both PRs sat in review for a while. The plan is to refactor both of these rules to remove the duplication while implementing #131205 Please consider "deduplicating code" out of scope for this PR.

[elasticmachine]

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

[elasticmachine]

Pinging @elastic/actionable-observability (Team: Actionable Observability)

[fkanout]

LGTM. Tested and the rule is executed with no issue after the fix.

[jasonrhodes]

@simianhacker so this looks like it's pulling two items off an existing array and storing them as numbered values? Can you help me understand what this actually changes?

[simianhacker]

@jasonrhodes This changes the format of the script so instead of writing the values as Painless constants, params.value > ${threshold[0]} ? 1 : 0 which would end up looking like params.value > 107374182400 ? 1 : 0, it uses script parameters. The primary issue with using constants is that for numbers larger than the max integer (32bit), you would have to properly cast them like (Long)107374182400 where when you use script parameters, Painless automatically cast them.

Functionality wise, it's the same but without the Painless casting error.

[jasonrhodes]

Ah ok, thanks for the explanation. These changes LGTM in general. I'll defer to you and @fkanout for the more complete testing but from our end,

[simianhacker]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 8c13705
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

✅ unchanged

History

• 💚 Build #48375 succeeded 1bb025d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation