Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] API integration tests for partition_fields_values endpoint #133519

Merged
merged 9 commits into from
Jun 7, 2022
Merged

[ML] API integration tests for partition_fields_values endpoint #133519

merged 9 commits into from
Jun 7, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jun 3, 2022 •
edited
Loading

Summary

Part of #130648

Adds API integration tests for partition_fields_values endpoint.

Checklist

@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration Team:ML Team label for ML (also use :ml) v8.3.0 labels Jun 3, 2022
@darnautov darnautov requested review from pheyos and peteharverson June 3, 2022 13:18
@darnautov darnautov requested a review from a team as a code owner June 3, 2022 13:18
@darnautov darnautov self-assigned this Jun 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov mentioned this pull request Jun 3, 2022
Closed
4 tasks
@darnautov darnautov added v8.4.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 3, 2022
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov requested a review from pheyos June 7, 2022 13:56
pheyos
pheyos approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov enabled auto-merge (squash) June 7, 2022 14:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 7206958 into elastic:main Jun 7, 2022
@darnautov darnautov deleted the ml-130648-partition-fields-values branch June 7, 2022 15:03
kibanamachine pushed a commit that referenced this pull request Jun 7, 2022
@darnautov
[ML] API integration tests for partition_fields_values endpoint (#1…
219d1ce 
…33519)

* api integration tests, improve type definitions

* refactor

* more tests

* tests for disabled model plot

* describe section

* runRequest function

* change maxRecordScore assertion

(cherry picked from commit 7206958)
@kibanamachine kibanamachine mentioned this pull request Jun 7, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 7, 2022
@kibanamachine @darnautov
[ML] API integration tests for partition_fields_values endpoint (#1…
8ae98a6 
…33519) (#133781)

* api integration tests, improve type definitions

* refactor

* more tests

* tests for disabled model plot

* describe section

* runRequest function

* change maxRecordScore assertion

(cherry picked from commit 7206958)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test-api-integration v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson