Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Remove vis type xy renderer #138735

Merged
merged 9 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ pageLoadAssetSize:
visTypeTimeseries: 55203
visTypeVega: 153573
visTypeVislib: 242838
visTypeXy: 113478
visTypeXy: 30000
visualizations: 90000
watcher: 43598
runtimeFields: 41752
Expand Down
11 changes: 11 additions & 0 deletions src/plugins/charts/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// TODO: https://github.com/elastic/kibana/issues/110891
/* eslint-disable @kbn/eslint/no_export_all */

import { RangeSelectContext, ValueClickContext } from '@kbn/embeddable-plugin/public';
import { ChartsPlugin } from './plugin';

export const plugin = () => new ChartsPlugin();
Expand All @@ -19,6 +20,16 @@ export * from './static';
export { lightenColor } from './services/palettes/lighten_color';
export { useActiveCursor } from './services/active_cursor';

export interface ClickTriggerEvent {
name: 'filter';
data: ValueClickContext['data'];
}

export interface BrushTriggerEvent {
name: 'brush';
data: RangeSelectContext['data'];
}

export type {
CustomPaletteArguments,
CustomPaletteState,
Expand Down
1 change: 0 additions & 1 deletion src/plugins/charts/public/static/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@

export * from './colors';
export * from './components';
export * from './utils';
export * from '../../common/static/styles';
9 changes: 0 additions & 9 deletions src/plugins/charts/public/static/utils/index.ts

This file was deleted.

282 changes: 0 additions & 282 deletions src/plugins/charts/public/static/utils/transform_click_event.ts

This file was deleted.

2 changes: 1 addition & 1 deletion src/plugins/vis_types/vislib/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"ui": true,
"requiredPlugins": ["charts", "data", "expressions", "visualizations", "fieldFormats"],
"optionalPlugins": ["usageCollection"],
"requiredBundles": ["kibanaUtils", "visTypeXy", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"],
"requiredBundles": ["kibanaUtils", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"],
"owner": {
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
* Side Public License, v 1.
*/

import { getAggId } from '@kbn/vis-type-xy-plugin/public';
import type { Dimension } from '@kbn/vis-type-xy-plugin/public';

import { Point } from './_get_point';

const getAggId = (accessor: string) => (accessor ?? '').split('-').pop() ?? '';

export interface Serie {
id: string;
rawId: string;
Expand Down
5 changes: 0 additions & 5 deletions src/plugins/vis_types/xy/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,3 @@ export enum ChartType {
Area = 'area',
Histogram = 'histogram',
}

/**
* Type of xy visualizations
*/
export type XyVisType = ChartType | 'horizontal_bar';
5 changes: 2 additions & 3 deletions src/plugins/vis_types/xy/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
"version": "kibana",
"ui": true,
"server": true,
"requiredPlugins": ["charts", "data", "expressions", "visualizations", "fieldFormats"],
"requiredBundles": ["kibanaUtils", "visDefaultEditor", "kibanaReact"],
"optionalPlugins": ["usageCollection"],
"requiredPlugins": ["charts", "visualizations", "data", "expressions"],
"requiredBundles": ["kibanaUtils", "visDefaultEditor"],
"extraPublicDirs": ["common/index"],
"owner": {
"name": "Vis Editors",
Expand Down
7 changes: 0 additions & 7 deletions src/plugins/vis_types/xy/public/_chart.scss

This file was deleted.

Loading