Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn-es-query] Add support for OR filters #142417

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

lukasolson
Copy link
Member

Summary

Adds support for OR filters in the kbn-es-query package, including generating the query DSL for these filters.
Moves relevant code out of the unified_search plugin (see #136815).

Checklist

For maintainers

@lukasolson lukasolson added Feature:Filters Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes Feature:Unified search Unified search related tasks v8.6.0 labels Sep 30, 2022
@lukasolson lukasolson self-assigned this Sep 30, 2022
@lukasolson lukasolson requested a review from a team as a code owner September 30, 2022 22:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 503 505 +2
apm 1314 1316 +2
canvas 1152 1154 +2
cloudSecurityPosture 187 189 +2
controls 202 204 +2
dashboard 390 392 +2
dashboardEnhanced 94 96 +2
data 519 521 +2
dataViewManagement 181 183 +2
dataVisualizer 378 380 +2
discover 534 536 +2
discoverEnhanced 72 74 +2
fleet 766 768 +2
graph 286 288 +2
infra 1006 1008 +2
inputControlVis 107 109 +2
lens 927 929 +2
lists 315 317 +2
maps 1001 1003 +2
ml 1623 1625 +2
monitoring 508 510 +2
observability 471 473 +2
osquery 316 318 +2
securitySolution 3146 3148 +2
stackAlerts 127 129 +2
synthetics 1001 1003 +2
threatIntelligence 216 218 +2
timelines 256 258 +2
transform 328 330 +2
triggersActionsUi 508 510 +2
unifiedFieldList 79 81 +2
unifiedSearch 229 231 +2
upgradeAssistant 198 200 +2
visTypeTimelion 107 109 +2
visTypeVega 230 232 +2
visualizations 357 359 +2
total +72

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/es-query 168 170 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 765.9KB 766.5KB +549.0B
apm 3.1MB 3.1MB +10.0B
canvas 1.0MB 1.0MB +10.0B
cloudSecurityPosture 202.9KB 203.4KB +552.0B
controls 458.6KB 459.1KB +549.0B
dashboard 418.7KB 419.4KB +743.0B
data 52.7KB 52.7KB +4.0B
dataViewManagement 148.6KB 149.2KB +552.0B
dataVisualizer 570.7KB 571.2KB +548.0B
discover 478.2KB 479.0KB +745.0B
discoverEnhanced 43.9KB 44.6KB +743.0B
fleet 911.6KB 911.6KB +10.0B
graph 451.5KB 451.5KB +10.0B
infra 1.0MB 1.0MB +549.0B
inputControlVis 78.2KB 78.3KB +10.0B
lens 1.3MB 1.3MB +743.0B
lists 152.6KB 152.6KB +10.0B
ml 3.4MB 3.4MB +548.0B
monitoring 479.7KB 479.8KB +10.0B
observability 526.6KB 527.2KB +546.0B
osquery 1.0MB 1.0MB +10.0B
stackAlerts 101.1KB 101.1KB +10.0B
synthetics 1.0MB 1.0MB +14.0B
threatIntelligence 113.1KB 113.7KB +552.0B
transform 388.3KB 388.9KB +549.0B
triggersActionsUi 672.7KB 672.7KB +10.0B
unifiedFieldList 54.4KB 55.0KB +549.0B
unifiedSearch 260.9KB 261.6KB +743.0B
upgradeAssistant 179.8KB 179.8KB +10.0B
visTypeTimelion 108.6KB 109.1KB +547.0B
visTypeVega 1.7MB 1.7MB +547.0B
visualizations 239.8KB 239.8KB +9.0B
total +10.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/es-query 12 14 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 42.8KB 42.8KB +10.0B
data 432.5KB 433.1KB +549.0B
maps 82.1KB 82.1KB +10.0B
securitySolution 263.9KB 264.5KB +549.0B
timelines 268.8KB 269.3KB +549.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
@kbn/es-query 222 226 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@ppisljar ppisljar merged commit 98f365e into elastic:main Oct 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
Co-authored-by: Peter Pisljar <peter.pisljar@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Co-authored-by: Peter Pisljar <peter.pisljar@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Filters Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants