-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Search] Create a filter builder component which works with nested OR/AND filters #136815
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Hi @ryankeairns , we have a question about styling. Currently the EuiPanel with the color 'plain' has no border. Is this normal or should we override the styles? |
@ppisljar could you please review this PR?! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No border is good, overrides are not needed. Thanks for asking. |
@elastic/security-onboarding-and-lifecycle-mgt, @elastic/security-threat-hunting-investigations, @elastic/security-solution, @elastic/kibana-data-discovery, @dasansol92, @paul-tavares we need your 👀 here. Сould you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! It works fine! We can revisit when we wire it with the unified search bar!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataDiscover.team Graph changes LGTM, there were just types and tests changed, did not test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature! Threat hunting investigations changes, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for Security Solution OLM team
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nlatipov |
Summary
This PR solve Step 1 of the issue ([Unified search] Complex filter capabilities - Support ORs) - Create a filter form component which will work with nested OR/AND filters
Notes:
The subtask
new component should be developed with the focus of what will become shared
will be implemented in another PRFilter.Builder.mov
What was done
FilterBuilder
component for creating nested filters with complex relationships (OR/AND);FilterBuilder
, the ability to add a filter with an AND and OR relation was implemented, as well as removing a filter;IDataPluginServices
has been replaced withIUnifiedSearchPluginServices
;add
andor
.add
andor
are visualized when moving the mouse cursor over the filter item while dragging;Add.Or.mov
params
input;getFilterByPath
,getConditionalOperationType
,getPathInArray
,addFilter
,removeFilter
,moveFilter
,normalizeFilters
;autocomplete
state has been removed from plugin's service and provided by kibana service;PhraseValueInput
,PhrasesValuesInput
andRangeValueInput
have been extended - the following fields have been added -compressed
,disabled
,isInvalid
;filter item
in accordance by designPhraseValueInput
andPhrasesValuesInput
components has been changed: the EuiFormRow component has been moved one level up, to thefilterEditor
component.