[RAM] Update Rule Status - UI Changes #144466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
…136039-rules-status
…-ref HEAD~1..HEAD --fix'
JiaweiWu
added
release_note:skip
|
Initial tests don't reveal anything yet. Just confirming some tests are underway. :) |
XavierM
reviewed
Nov 15, 2022
x-pack/plugins/triggers_actions_ui/public/application/lib/rule_api/map_filters_to_kuery_node.ts
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
...ctions_ui/public/application/sections/rule_details/components/rule_event_log_list_status.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
...s/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
...ctions_ui/public/application/sections/rules_list/components/rule_last_run_outcome_filter.tsx
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
...riggers_actions_ui/public/application/sections/rules_list/components/rules_list_statuses.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
XavierM
reviewed
Nov 15, 2022
| @@ -465,7 +490,7 @@ export const RulesList = ({ | |||
| setShowErrors((prevValue) => { | |||
| if (!prevValue) { | |||
| const rulesToExpand = rulesState.data.reduce((acc, ruleItem) => { | |||
| if (ruleItem.executionStatus.status === 'error') { | |||
| if (ruleItem.lastRun?.outcome === RuleLastRunOutcomeValues[2]) { | |||
There was a problem hiding this comment.
Should we check the feature flag and have two conditions instead of one or just a OR
XavierM
reviewed
Nov 15, 2022
x-pack/plugins/triggers_actions_ui/public/common/lib/rule_status_helpers.ts
Show resolved
Hide resolved
XavierM
reviewed
Nov 15, 2022
| }); | ||
| await refreshAlertsList(); | ||
| await find.waitForDeletedByCssSelector('.euiBasicTable-loading'); | ||
| await testSubjects.click('ruleExecutionStatusFilterButton'); |
There was a problem hiding this comment.
@JiaweiWu and I talked more about it and we think we should add a new config file to allow this test working when the feature flag is off. We will create an issue to add back this test until the feature flag exists
|
While testing the experimental flags I noticed we have a small bug in our experimental features getters. I will create an issue and work on that immediately after FF (#145300) |
|
@elasticmachine merge upstream |
XavierM
approved these changes
Nov 15, 2022
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
1 task
jcger
pushed a commit
that referenced
this pull request
Nov 16, 2022
## Summary In the PR that updated and consolidated rule status (#144466). The new helper that was added had references to translations, which increased the `triggers_actions_ui` bundle size by quite a bit. This PR refactors the helper so we're passing in the translations. It seems like a good compromise to allow some logic reuse but without the massive bundle increase. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent issue for updating rule status: #136039
Frontend issue: #145191
Backend PR: #140882
Updates the rules list and rules details page to support the new consolidated statuses. With E2E and unit testing.
Rules list:
Rule details:
Checklist