Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes bulk close alerts from exception flyout type bug #150765

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[Security Solution] Fixes bulk close alerts from exception flyout type bug #150765

merged 2 commits into from
Feb 9, 2023

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Feb 9, 2023 •
edited by kibanamachine
Loading

Summary

Addresses #149971 which was stopping users from bulk closing alerts from the exception flyout when they added new comments to the exception item

This strips out unneeded attributes before that api call thus fixing the type errors without changing the final return value

Checklist

Delete any items that are not applicable to this PR.

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team v8.7.0 labels Feb 9, 2023
@dplumlee dplumlee self-assigned this Feb 9, 2023
@dplumlee dplumlee requested a review from a team as a code owner February 9, 2023 18:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dplumlee dplumlee requested a review from a team February 9, 2023 18:39
@dplumlee dplumlee added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Feb 9, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.8MB 13.8MB +112.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@marshallmain
Copy link
Contributor

LGTM, no longer see the error when following the steps below and the alert gets closed.
(1) edit an existing rule exception, (2) add a new comment while editing the exception, and (3) check the Close all alerts that match this exception and were generated by selected rule/s box before saving the edits

@dplumlee dplumlee merged commit 216fb3a into elastic:main Feb 9, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
@dplumlee
[Security Solution] Fixes bulk close alerts from exception flyout typ…
a180585 
…e bug (elastic#150765)

(cherry picked from commit 216fb3a)
This was referenced Feb 9, 2023
Merged
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
@dplumlee
[Security Solution] Fixes bulk close alerts from exception flyout typ…
b7f412a 
…e bug (elastic#150765)

(cherry picked from commit 216fb3a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2023
@kibanamachine @dplumlee
[8.6] [Security Solution] Fixes bulk close alerts from exception flyo…
6de4151 
…ut type bug (#150765) (#150783)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Fixes bulk close alerts from exception flyout
type bug (#150765)](#150765)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-09T21:00:07Z","message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:
SecuritySolution","Team:Detection
Alerts","backport:prev-minor","v8.7.0","v8.6.2","v8.8.0"],"number":150765,"url":"https://github.com/elastic/kibana/pull/150765","mergeCommit":{"message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.6"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150765","number":150765,"mergeCommit":{"message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85"}}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
@dplumlee dplumlee deleted the edit-exception-type-bug branch February 9, 2023 23:36
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 10, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
a9b2e06 
* main: (115 commits)
  [Custom branding] Add custom logo to space selector (elastic#150284)
  [api-docs] 2023-02-10 Daily api_docs build (elastic#150831)
  [ci] build next docs in PRs when relevant files change (elastic#149991)
  [codeowners] allow overrides to take higher precedence (elastic#150821)
  [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788)
  [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780)
  [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761)
  fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768)
  [Synthetics] adjust overview scrolling e2e (elastic#150774)
  [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765)
  Upgrade EUI to v74.1.0 (elastic#150235)
  [skip ci] Fix labeling for Infrastructure UI (elastic#150571)
  [Enterprise Search] Move pipelines modal to flyout (elastic#150727)
  [Security Solution] fix flaky endpoint tests (elastic#150652)
  Fixes the space selector page layout  (elastic#150503)
  [Dashboard] [Navigation] Fix mount point bug (elastic#150507)
  [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685)
  [Dashboard Usability] Moves scrollbar to panel section (elastic#145628)
  [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497)
  [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394)
  ...
kibanamachine added a commit that referenced this pull request Feb 14, 2023
@kibanamachine @dplumlee
[8.7] [Security Solution] Fixes bulk close alerts from exception flyo…
3aaa46a 
…ut type bug (#150765) (#150784)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Fixes bulk close alerts from exception flyout
type bug (#150765)](#150765)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-09T21:00:07Z","message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:
SecuritySolution","Team:Detection
Alerts","backport:prev-minor","v8.7.0","v8.6.2","v8.8.0"],"number":150765,"url":"https://github.com/elastic/kibana/pull/150765","mergeCommit":{"message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.6"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150765","number":150765,"mergeCommit":{"message":"[Security
Solution] Fixes bulk close alerts from exception flyout type bug
(#150765)","sha":"216fb3a1806d67c35e7ee84353d4d6460f87ad85"}}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshallmain marshallmain marshallmain approved these changes

Assignees

@dplumlee dplumlee

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:fix Team:Detection Alerts Security Detection Alerts Area Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.2 v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibana-ci @marshallmain @kibanamachine