Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] adjust overview scrolling e2e #150774

Merged

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Feb 9, 2023

Summary

Adjusts the scrolling mechanism for synthetics scrolling test.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 v8.8.0 labels Feb 9, 2023
@dominiqueclarke dominiqueclarke changed the title synthetics - adjust overview scrolling e2e [Synthetics] adjust overview scrolling e2e Feb 9, 2023
@dominiqueclarke dominiqueclarke marked this pull request as ready for review February 9, 2023 19:55
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner February 9, 2023 19:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke added the release_note:skip Skip the PR/issue when compiling release notes label Feb 9, 2023
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. WFG. Didn't do any practical testing for this one.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 576c92c into elastic:main Feb 9, 2023
@dominiqueclarke dominiqueclarke deleted the fix/overview-scrolling branch February 9, 2023 21:34
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.7 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.7:
- [Synthetics] Update scrolling e2e test (#150673)

Manual backport

To create the backport manually run:

node scripts/backport --pr 150774

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Feb 9, 2023
## Summary

Adjusts the scrolling mechanism for synthetics scrolling test.

(cherry picked from commit 576c92c)

# Conflicts:
#	x-pack/plugins/synthetics/e2e/journeys/synthetics/overview_scrolling.journey.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 10, 2023
* main: (115 commits)
  [Custom branding] Add custom logo to space selector (elastic#150284)
  [api-docs] 2023-02-10 Daily api_docs build (elastic#150831)
  [ci] build next docs in PRs when relevant files change (elastic#149991)
  [codeowners] allow overrides to take higher precedence (elastic#150821)
  [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788)
  [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780)
  [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761)
  fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768)
  [Synthetics] adjust overview scrolling e2e (elastic#150774)
  [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765)
  Upgrade EUI to v74.1.0 (elastic#150235)
  [skip ci] Fix labeling for Infrastructure UI (elastic#150571)
  [Enterprise Search] Move pipelines modal to flyout (elastic#150727)
  [Security Solution] fix flaky endpoint tests (elastic#150652)
  Fixes the space selector page layout  (elastic#150503)
  [Dashboard] [Navigation] Fix mount point bug (elastic#150507)
  [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685)
  [Dashboard Usability] Moves scrollbar to panel section (elastic#145628)
  [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497)
  [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394)
  ...
dominiqueclarke added a commit that referenced this pull request Feb 10, 2023
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics] adjust overview scrolling e2e
(#150774)](#150774)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T21:34:05Z","message":"[Synthetics]
adjust overview scrolling e2e (#150774)\n\n## Summary\r\n\r\nAdjusts the
scrolling mechanism for synthetics scrolling
test.","sha":"576c92ce7fc7521f7059e24a54ffbec8156f4668","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":150774,"url":"https://github.com/elastic/kibana/pull/150774","mergeCommit":{"message":"[Synthetics]
adjust overview scrolling e2e (#150774)\n\n## Summary\r\n\r\nAdjusts the
scrolling mechanism for synthetics scrolling
test.","sha":"576c92ce7fc7521f7059e24a54ffbec8156f4668"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150774","number":150774,"mergeCommit":{"message":"[Synthetics]
adjust overview scrolling e2e (#150774)\n\n## Summary\r\n\r\nAdjusts the
scrolling mechanism for synthetics scrolling
test.","sha":"576c92ce7fc7521f7059e24a54ffbec8156f4668"}}]}] BACKPORT-->

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants