[ResponseOps] provide config to turn off email action footer #154919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuellr
force-pushed
the
alerting/email-footer
branch
from
2e9612e to
eb8d22c
Compare
pmuellr
added
Feature:Alerting
release_note:skip
pmuellr
force-pushed
the
alerting/email-footer
branch
from
c14caf5 to
c1a10fd
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
ymao1
approved these changes
Apr 17, 2023
| @@ -130,6 +130,9 @@ A list of allowed email domains which can be used with the email connector. When | |||
|
|
|||
| WARNING: This feature is available in {kib} 7.17.4 and 8.3.0 onwards but is not supported in {kib} 8.0, 8.1 or 8.2. As such, this setting should be removed before upgrading from 7.17 to 8.0, 8.1 or 8.2. It is possible to configure the settings in 7.17.4 and then upgrade to 8.3.0 directly. | |||
|
|
|||
| `xpack.actions.enableFooterInEmail` {ess-icon}:: | |||
There was a problem hiding this comment.
Should we also add this to the docker allowlist?
There was a problem hiding this comment.
yup - opened https://github.com/elastic/cloud/issues/113918 to track
There was a problem hiding this comment.
The docker allowlist is here src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker :)
There was a problem hiding this comment.
ah crap - I thought it was all the in cloud repo 🤦🏻!
Just merged this and saw this comment, so will open another PR to add it there ... thx!
There was a problem hiding this comment.
merged that fix here: #155076
pmuellr
added a commit
that referenced
this pull request
Apr 17, 2023
) ## Summary In PR #154919, we forgot to add the config to the docker allow-list in the appropriate file. We add it in this PR.
pmuellr
added
release_note:enhancement
and removed
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #135402
Release note
Adds a new Kibana configuration setting
xpack.actions.enableFooterInEmailto allow the footer added to emails sent from Kibana alerting rules to NOT be added. The footer is still added by default, or if the setting valuetrueis used.When set to
false, the footer will not be added to the email.Summary
Footers were added to emails sent as alerting actions in #84371. In this PR, we provide a config option to turn it off -
xpack.actions.enableFooterInEmail- defaulttrue.This should be cloud-enabled by making the appropriate changes in that repo.
Drive-by fix: I noticed in the original PR, I had made a comment about using
---before the footer instead of--- it renders better. Decided to make that fix here as well. Comparison:before:
after:
Checklist
Delete any items that are not applicable to this PR.