You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukas and I chatted over Slack and we both agreed it didn't really make sense to apply query:queryString:options to query_string filters. If someone is using the advanced query DSL editor to create a query_string filter they probably want full control over it.
This is a breaking change so it will only go in 7.0. In 6.x users should use one of the workarounds.
After thinking about this some more, I think it might actually make sense to add the query:queryString:options to query_string filters. This is because editing the query DSL of a filter is not the only way to get a query_string filter. Another way is to create a visualization and use the "Filters" aggregation. I think it does make sense for the filters that are created from clicking on of these to send the params. Thoughts?
@lukasolson I agree those should have query:queryString:options applied, but it already works that way. The createFilter helper for the filters agg calls toDSL on the aggConfig. This calls the write method on the filters aggType which uses decorateQuery.
Can you add breaking change docs for this in this PR? I think this would be the first one for 7.0, so you might need to do some basic setup for the 7.0 breaking change docs.
Since this isn't active right now I'm removing myself as a reviewer, just to clean up my "reviews requested of you" view. Just pop me back on whenever it's ready to go again.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bargs
force-pushed
the
queryStringFilter
branch
from
Fixes #15527
Lukas and I chatted over Slack and we both agreed it didn't really make sense to apply
query:queryString:optionsto query_string filters. If someone is using the advanced query DSL editor to create a query_string filter they probably want full control over it.This is a breaking change so it will only go in 7.0. In 6.x users should use one of the workarounds.