[6.x] Simplify Courier interface and organize internals (#20060) #20285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
retest |
💔 Build Failed |
**Interface changes** There are two goals behind the interface changes: * Make it clearer which courier modules are meant for public consumption by exporting them from the top level. * Simplify the courier object by removing responsibilities and focusing its responsibility solely on scheduling search requests via the fetch method and timefilter.refreshInterval Angular event. I did this by taking the following steps: * Removing redirectWhenMissing, indexPatterns, SearchSource, and SavedObject from the courier object. I also removed some unused methods from its interface. * redirectWhenMissing is now a service registered on the kibana/url Angular module. * indexPatterns is now a service registered on the kibana/index_patterns Angular module. * SearchSourceProvider and SavedObjectProvider are now top-level exports of ui/courier. * migrateFilter, decorateQuery, buildQueryFromFilters, and luceneStringToDsl are now top-level exports of ui/courier. **Internal changes** I also made some internal changes in an effort to organize the code clearly and reduce unnecessary complexity. * I refactored the async code in CallClient to appear sync with async/await and encapsulated chunks of logic in helper functions. I also used an isAborted flag instead of overwriting the esPromise var with an enum. * I combined Looper and SearchLooper into a single class and deleted unused functions. * I reorganized the courier/fetch/request code into SearchRequest, SegmentedSearchRequest, and serializeFetchParams modules. * Renamed various other methods and variables to improve clarity.
cjcenizal
force-pushed
the
backport/20060/6.x
branch
from
7687b24 to
2e1bf95
Compare
|
The divergence between this PR's diff and that of the original is due to:
These files have additional changes in them because #15640 touched these files but was only applied to master, and not backported to 6.x |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #20060