Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Fix issue with alert summary widget refresh on the Alerts page #160159

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[AO] Fix issue with alert summary widget refresh on the Alerts page #160159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba0503
Update absolute time range when refresh button is clicked
maryam-saeidi Jun 21, 2023
3a61500
Merge branch 'main' into fix-alert-summary-refresh
maryam-saeidi Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion x-pack/plugins/observability/public/pages/alerts/alerts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ function InternalAlertsPage() {
bucketSize?.intervalString || DEFAULT_INTERVAL,
bucketSize?.dateFormat || DEFAULT_DATE_FORMAT
),
[alertSearchBarStateProps.rangeFrom, alertSearchBarStateProps.rangeTo, bucketSize]
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: if you take in esQuery into the getAlertSummaryTimeRange function, ESLint won't complain about the unnecessary dependency

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by moving esQuery into the getAlertSummaryTimeRange function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge my PR, but if you share with me details of your suggestion, I can cover it in my future PRs

[alertSearchBarStateProps.rangeFrom, alertSearchBarStateProps.rangeTo, bucketSize, esQuery]
);

useBreadcrumbs([
Expand Down