Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transform: Enable accessibility tests #160649

Merged
merged 6 commits into from
Jul 17, 2023
Merged

[ML] Transform: Enable accessibility tests #160649

merged 6 commits into from
Jul 17, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jun 27, 2023 •
edited
Loading

Summary

Resolves #160382

Checklist

@peteharverson peteharverson mentioned this pull request Jun 28, 2023
Closed
9 tasks
@darnautov darnautov self-assigned this Jul 11, 2023
@darnautov
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2602

@darnautov darnautov mentioned this pull request Jul 17, 2023
Closed
13 tasks
@darnautov
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2650

@darnautov darnautov added :ml Team:ML Team label for ML (also use :ml) v8.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 17, 2023
@darnautov darnautov marked this pull request as ready for review July 17, 2023 14:37
@darnautov darnautov requested a review from a team as a code owner July 17, 2023 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

darnautov
darnautov commented Jul 17, 2023
View reviewed changes
x-pack/test/accessibility/apps/transform.ts
@@ -147,7 +147,7 @@ export default function ({ getService }: FtrProviderContext) {
await a11y.testAppSnapshot();
});

it('create pivot transform configuration step JSON editor', async () => {
it.skip('create pivot transform configuration step JSON editor', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test was crashing the browser instance in CI, presumably because a CodeEditor instance (powered by monaco) consumes too much memory. Locally it was ok on my machine though.

peteharverson
peteharverson approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Locally without the skip on the JSON editor test, it fails every time (WSL). With the skip the rest of the tests pass.

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) July 17, 2023 15:30
@darnautov darnautov merged commit e248faa into elastic:main Jul 17, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 17, 2023
@darnautov darnautov deleted the ml-160382-fix-transform-tests branch July 17, 2023 20:15
@peteharverson peteharverson mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos Awaiting requested review from pheyos

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Transforms: Accessibility tests failing in after all hook with NoSuchSessionError
5 participants
@darnautov @elasticmachine @kibana-ci @peteharverson @kibanamachine