Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transform: Enable accessibility tests #160649

Merged
merged 6 commits into from
Jul 17, 2023
Merged

[ML] Transform: Enable accessibility tests #160649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
552e636
enable transform a11y tests
darnautov Jun 27, 2023
3c012bc
Merge remote-tracking branch 'origin/main' into ml-160382-fix-transfo…
darnautov Jun 27, 2023
5493ef0
remove comments
darnautov Jun 28, 2023
9350bda
Merge remote-tracking branch 'origin/main' into ml-160382-fix-transfo…
darnautov Jul 11, 2023
46dffb1
skip json editor test
darnautov Jul 17, 2023
9bcfd99
Merge branch 'main' into ml-160382-fix-transform-tests
kibanamachine Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/test/accessibility/apps/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default function ({ getService }: FtrProviderContext) {
const a11y = getService('a11y');
const transform = getService('transform');

describe('transform Accessibility', () => {
describe('transform Accessibility', function () {
const esArchiver = getService('esArchiver');

before(async () => {
Expand Down Expand Up @@ -147,7 +147,7 @@ export default function ({ getService }: FtrProviderContext) {
await a11y.testAppSnapshot();
});

it('create pivot transform configuration step JSON editor', async () => {
it.skip('create pivot transform configuration step JSON editor', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test was crashing the browser instance in CI, presumably because a CodeEditor instance (powered by monaco) consumes too much memory. Locally it was ok on my machine though.

await transform.testExecution.logTestStep('displays the JSON pivot configuration');
await transform.wizard.assertAdvancedPivotEditorSwitchExists();
await transform.wizard.enableAdvancedPivotEditor();
Expand Down
4 changes: 1 addition & 3 deletions x-pack/test/accessibility/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
require.resolve('./apps/roles'),
require.resolve('./apps/ingest_node_pipelines'),
require.resolve('./apps/index_lifecycle_management'),
// https://github.com/elastic/kibana/issues/153596
// https://github.com/elastic/kibana/issues/153592
require.resolve('./apps/ml'),
// require.resolve('./apps/transform'),
require.resolve('./apps/transform'),
require.resolve('./apps/lens'),
require.resolve('./apps/upgrade_assistant'),
require.resolve('./apps/canvas'),
Expand Down