-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Load sample data in serverless #165157
Conversation
Pinging @elastic/appex-sharedux (Team:SharedUX) |
…-ref HEAD~1..HEAD --fix'
@@ -100,5 +100,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
await testSubjects.missingOrFail('rollup-tag'); | |||
}); | |||
}); | |||
it('Sample data loads', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have this test added to a separate test file (e.g. sample_data.ts
) next to this file? It is accessed through data views but is not a feature of data views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a1cb601 for changes thanks!!!
@@ -14,7 +14,7 @@ import { FtrProviderContext } from '../../ftr_provider_context'; | |||
const archivePath = 'test/api_integration/fixtures/es_archiver/index_patterns/basic_index'; | |||
|
|||
export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
const PageObjects = getPageObjects(['settings', 'common', 'header']); | |||
const PageObjects = getPageObjects(['settings', 'common', 'header', 'home']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is not required anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 803a267 for changes!
Ability to load sample data is being used as a basic smoke for kibana availability in serverless. Please can we get this change applied. |
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsMetrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: cc @rshen91 |
Summary
Closes #165114
Closes #165368
Unable to create sample data index "kibana_sample_data_flights", error: illegal_argument_exception Root causes: illegal_argument_exception: Settings [index.auto_expand_replicas,index.number_of_shards] are not available when running in serverless mode
found in logs in the message field when filtering by project by kubernetes.labels.k8s_elastic_co/project-id: "d660f827d17a4e3f9662d473461c099c"