Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Load sample data in serverless #165157

Merged
merged 67 commits into from
Sep 8, 2023
Merged

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Aug 29, 2023

Summary

Closes #165114
Closes #165368

Unable to create sample data index "kibana_sample_data_flights", error: illegal_argument_exception Root causes: illegal_argument_exception: Settings [index.auto_expand_replicas,index.number_of_shards] are not available when running in serverless mode

Screenshot 2023-08-30 at 11 21 03 AM

found in logs in the message field when filtering by project by kubernetes.labels.k8s_elastic_co/project-id: "d660f827d17a4e3f9662d473461c099c"

  • TODO set up FTR that should have caught this to confirm this fix works in serverless environments (based off the home page object)

@rshen91 rshen91 self-assigned this Aug 29, 2023
@rshen91 rshen91 added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 29, 2023
@rshen91 rshen91 marked this pull request as ready for review August 30, 2023 17:26
@rshen91 rshen91 requested a review from a team as a code owner August 30, 2023 17:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@rshen91 rshen91 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 30, 2023
@rshen91
Copy link
Contributor Author

rshen91 commented Sep 6, 2023

Tests might be failing due to similar issue in #165414 wdyt @sebelga 🤔 ?

@@ -100,5 +100,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.missingOrFail('rollup-tag');
});
});
it('Sample data loads', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have this test added to a separate test file (e.g. sample_data.ts) next to this file? It is accessed through data views but is not a feature of data views.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a1cb601 for changes thanks!!!

@sebelga
Copy link
Contributor

sebelga commented Sep 7, 2023

Tests might be failing due to similar issue in #165414 wdyt @sebelga 🤔 ?

Yes it seems related. It was previously skipped for #165386 @Dosant is looking into it

@rshen91 rshen91 added the ci:cloud-redeploy Always create a new Cloud deployment label Sep 7, 2023
@rshen91 rshen91 requested a review from sebelga September 7, 2023 13:41
@rshen91 rshen91 enabled auto-merge (squash) September 7, 2023 15:44
@@ -14,7 +14,7 @@ import { FtrProviderContext } from '../../ftr_provider_context';
const archivePath = 'test/api_integration/fixtures/es_archiver/index_patterns/basic_index';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['settings', 'common', 'header']);
const PageObjects = getPageObjects(['settings', 'common', 'header', 'home']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is not required anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 803a267 for changes!

@sophiec20
Copy link
Contributor

Ability to load sample data is being used as a basic smoke for kibana availability in serverless. Please can we get this change applied.

@Dosant
Copy link
Contributor

Dosant commented Sep 8, 2023

@elasticmachine merge upstream

@rshen91 rshen91 requested a review from sebelga September 8, 2023 13:21
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 8, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5594 +5594
total size - 6.0MB +6.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit 41b124d into elastic:main Sep 8, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-serverless-image ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0
Projects
None yet
10 participants