-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Load sample data in serverless #165157
Changes from 59 commits
cc8fc96
f013a11
e3a81cb
877bc78
8685167
8d04ec6
dd63d36
011f59c
76d0391
b6434bf
3ad6a11
1f65979
5219dd7
2c02b6b
4e770b1
7466f1e
631d9d7
92f843d
aa63c80
bcebbe7
54d000d
4d94b86
ecfc51e
8a1ba57
0df2c52
23deb82
db701fd
960fbbe
1896176
b25d148
b06ab53
02caddf
eb144b6
4d0105c
27a7f1a
37e1cda
2d3da64
2d4955a
a1d1110
654f3bc
00c5431
ff738f3
b04981c
18574c7
101d04b
8b43293
59c03aa
2e3df62
269a7b8
7589c87
832191b
308094d
c1d6d76
2353369
f5c4ab6
4a4d4de
bd09d5b
8d8c67f
d3fec32
d9f5ef7
8cd062b
5fcb860
a1cb601
967167b
a759617
07104b5
803a267
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ import { FtrProviderContext } from '../../ftr_provider_context'; | |
const archivePath = 'test/api_integration/fixtures/es_archiver/index_patterns/basic_index'; | ||
|
||
export default function ({ getService, getPageObjects }: FtrProviderContext) { | ||
const PageObjects = getPageObjects(['settings', 'common', 'header']); | ||
const PageObjects = getPageObjects(['settings', 'common', 'header', 'home']); | ||
const esArchiver = getService('esArchiver'); | ||
const supertest = getService('supertest'); | ||
const testSubjects = getService('testSubjects'); | ||
|
@@ -100,5 +100,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |
await testSubjects.missingOrFail('rollup-tag'); | ||
}); | ||
}); | ||
it('Sample data loads', async () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we have this test added to a separate test file (e.g. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a1cb601 for changes thanks!!! |
||
await PageObjects.home.addSampleDataSet('ecommerce'); | ||
const ecommerce = await PageObjects.home.isSampleDataSetInstalled('ecommerce'); | ||
expect(ecommerce).toBe(true); | ||
}); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is not required anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 803a267 for changes!