Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ML swimlane embeddable titles #168647

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Fix ML swimlane embeddable titles #168647

merged 4 commits into from
Oct 13, 2023

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Oct 11, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #165967

The ML Embeddables were setting the default title and default description on their outputs during initialization. These keys should only be used by by reference visualizations to default back to the library item title. Initializing them to undefined especially can result in edge cases.

@ThomThomson ThomThomson added Feature:Embedding Embedding content via iFrame :ml Feature:Anomaly Detection ML anomaly detection Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 11, 2023
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #74 / security app field_level_security "after all" hook for "user customer2 should not see ssn"
  • [job] [logs] FTR Configs #74 / security app field_level_security should add new role a_viewssnrole

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 587.2KB 587.2KB -20.0B
ml 3.5MB 3.5MB -159.0B
total -179.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review October 12, 2023 21:54
@ThomThomson ThomThomson requested a review from a team as a code owner October 12, 2023 21:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added the release_note:skip Skip the PR/issue when compiling release notes label Oct 12, 2023
@darnautov
Copy link
Contributor

Tested and LGTM! Many thanks for fixing it @ThomThomson 🙏🏻

@ThomThomson ThomThomson merged commit 7cb153d into elastic:main Oct 13, 2023
6 checks passed
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2023
@ThomThomson
Fix ML swimlane embeddable titles (elastic#168647)
ede45a5 
Stops the ML Embeddables from setting the default title and default description on their outputs during initialization.

(cherry picked from commit 7cb153d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 13, 2023
@kibanamachine @ThomThomson
[8.11] Fix ML swimlane embeddable titles (#168647) (#168846)
7f8909a 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Fix ML swimlane embeddable titles
(#168647)](#168647)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-10-13T13:28:57Z","message":"Fix
ML swimlane embeddable titles (#168647)\n\nStops the ML Embeddables from
setting the default title and default description on their outputs
during
initialization.","sha":"7cb153d4d7344212c437553655d980b02b4b355b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding",":ml","Feature:Anomaly
Detection","Team:Presentation","loe:small","release_note:skip","impact:medium","v8.11.0","v8.12.0"],"number":168647,"url":"https://github.com/elastic/kibana/pull/168647","mergeCommit":{"message":"Fix
ML swimlane embeddable titles (#168647)\n\nStops the ML Embeddables from
setting the default title and default description on their outputs
during
initialization.","sha":"7cb153d4d7344212c437553655d980b02b4b355b"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168647","number":168647,"mergeCommit":{"message":"Fix
ML swimlane embeddable titles (#168647)\n\nStops the ML Embeddables from
setting the default title and default description on their outputs
during
initialization.","sha":"7cb153d4d7344212c437553655d980b02b4b355b"}}]}]
BACKPORT-->

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@ThomThomson @dej611
Fix ML swimlane embeddable titles (elastic#168647)
a630e6b 
Stops the ML Embeddables from setting the default title and default description on their outputs during initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort :ml release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Panel settings inconsistent behaviour with ML embeddables
5 participants
@ThomThomson @kibana-ci @elasticmachine @darnautov @kibanamachine