Skip to content

Commit

Permalink
Fix ML swimlane embeddable titles (elastic#168647)
Browse files Browse the repository at this point in the history
Stops the ML Embeddables from setting the default title and default description on their outputs during initialization.

(cherry picked from commit 7cb153d)
  • Loading branch information
ThomThomson committed Oct 13, 2023
1 parent 7c688c4 commit ede45a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class EmbeddableChangePointChart extends AbstractEmbeddable<
initialInput: EmbeddableChangePointChartInput,
parent?: IContainer
) {
super(initialInput, { defaultTitle: initialInput.title }, parent);
super(initialInput, {}, parent);

this.initOutput().finally(() => this.setInitializationFinished());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,7 @@ export abstract class AnomalyDetectionEmbeddable<
private dataViewsService: DataViewsContract,
parent?: IContainer
) {
super(
initialInput,
{
defaultTitle: initialInput.title,
defaultDescription: initialInput.description,
} as Output,
parent
);
super(initialInput, {} as Output, parent);

this.initializeOutput(initialInput).finally(() => {
this.setInitializationFinished();
Expand Down

0 comments on commit ede45a5

Please sign in to comment.