[docs] Add comment about ftr test environment differences #169596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
jbudz
approved these changes
Oct 23, 2023
grammar correction Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2023
…9596) Skipped tests are release blockers and fixing flaky tests isn't always easy, especially if we assume that if a test passes locally, it will also pass in CI. We need to keep the differences between our local environments and CI in mind and make appropriate changes that take these differences into account but to do that, we first need to know what these differences are! This PR adds a high level description of a couple of key differences. ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials --------- Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> (cherry picked from commit 456d980)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2023
…9596) (#169665) # Backport This will backport the following commits from `main` to `8.11`: - [[docs] Add comment about ftr test environment differences (#169596)](#169596) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-10-24T14:46:03Z","message":"[docs] Add comment about ftr test environment differences (#169596)\n\nSkipped tests are release blockers and fixing flaky tests isn't always\r\neasy, especially if we assume that if a test passes locally, it will\r\nalso pass in CI.\r\n\r\nWe need to keep the differences between our local environments and CI in\r\nmind and make appropriate changes that take these differences into\r\naccount but to do that, we first need to know what these differences\r\nare!\r\n\r\nThis PR adds a high level description of a couple of key differences.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: Alejandro Fernández Haro <afharo@gmail.com>","sha":"456d980e771846ee82ae246c7fca204d4a4c9f50","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.12.0"],"number":169596,"url":"https://github.com/elastic/kibana/pull/169596","mergeCommit":{"message":"[docs] Add comment about ftr test environment differences (#169596)\n\nSkipped tests are release blockers and fixing flaky tests isn't always\r\neasy, especially if we assume that if a test passes locally, it will\r\nalso pass in CI.\r\n\r\nWe need to keep the differences between our local environments and CI in\r\nmind and make appropriate changes that take these differences into\r\naccount but to do that, we first need to know what these differences\r\nare!\r\n\r\nThis PR adds a high level description of a couple of key differences.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: Alejandro Fernández Haro <afharo@gmail.com>","sha":"456d980e771846ee82ae246c7fca204d4a4c9f50"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169596","number":169596,"mergeCommit":{"message":"[docs] Add comment about ftr test environment differences (#169596)\n\nSkipped tests are release blockers and fixing flaky tests isn't always\r\neasy, especially if we assume that if a test passes locally, it will\r\nalso pass in CI.\r\n\r\nWe need to keep the differences between our local environments and CI in\r\nmind and make appropriate changes that take these differences into\r\naccount but to do that, we first need to know what these differences\r\nare!\r\n\r\nThis PR adds a high level description of a couple of key differences.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: Alejandro Fernández Haro <afharo@gmail.com>","sha":"456d980e771846ee82ae246c7fca204d4a4c9f50"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
adamkasztenny
added a commit
to adamkasztenny/kibana
that referenced
this pull request
Oct 24, 2023
Follow up to elastic#169596
adamkasztenny
added a commit
that referenced
this pull request
Oct 24, 2023
## Summary Follow up to #169596 --------- Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2023
## Summary Follow up to elastic#169596 --------- Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> (cherry picked from commit 6f30fa3)
kibanamachine
referenced
this pull request
Oct 24, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[docs] Fix functional test doc formatting (#169715)](#169715) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Adam Kasztenny","email":"adam.kasztenny@elastic.co"},"sourceCommit":{"committedDate":"2023-10-24T20:45:52Z","message":"[docs] Fix functional test doc formatting (#169715)\n\n## Summary\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/169596\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>","sha":"6f30fa32857fa8352c50327ecb55e60e1f879a29","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.12.0"],"number":169715,"url":"https://github.com/elastic/kibana/pull/169715","mergeCommit":{"message":"[docs] Fix functional test doc formatting (#169715)\n\n## Summary\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/169596\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>","sha":"6f30fa32857fa8352c50327ecb55e60e1f879a29"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169715","number":169715,"mergeCommit":{"message":"[docs] Fix functional test doc formatting (#169715)\n\n## Summary\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/169596\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>","sha":"6f30fa32857fa8352c50327ecb55e60e1f879a29"}}]}] BACKPORT--> Co-authored-by: Adam Kasztenny <adam.kasztenny@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipped tests are release blockers and fixing flaky tests isn't always easy, especially if we assume that if a test passes locally, it will also pass in CI.
We need to keep the differences between our local environments and CI in mind and make appropriate changes that take these differences into account but to do that, we first need to know what these differences are!
This PR adds a high level description of a couple of key differences.
Checklist
Delete any items that are not applicable to this PR.