[SecuritySolution] Panel Settings of visualizations not working

[angorayc]

Summary

#168670

Before: Panel Settings displayed in SecuritySolution visualisations and SecuritySolution dashboards panel actions. However, the panel settings do not work with visualisations in SecuritySolution.

After: Panel Settings displayed in dashboards only (as we have withDefaultActions = false in SecuritySolution Lens Embeddables)

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 0da9ebe

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
embeddable	78.3KB	78.4KB	+55.0B

History

• 💔 Build #172251 failed 54dcba2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[ThomThomson]

Hey @angorayc!

I'm currently in the middle of a major refactor of the Embeddable code, so if possible I'd like to avoid changes to it. Rather than changing the base embeddable implementation to include withDefaultActions, would it be possible to add ACTION_CUSTOMIZE_PANEL to the disabledActions array anywhere this is used? That should accomplish the same thing with fewer changes. It's not an ideal solution because you'd need to individually disable actions as they get added, but it should work well enough for now.

It looks like this problem is caused because some of the Embeddable panel actions skip the registry, instead being called universalActions, so the current withDefaultActions implementation doesn't remove them properly. In my refactor, I've removed universalActions so all actions go through the registry.