[SecuritySolution] Disable Panel Settings for visualization context menu #174183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
angorayc
added
the
release_note:skip
Closed
3 tasks
stephmilovic
approved these changes
Jan 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @angorayc |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 4, 2024
…enu (elastic#174183) ## Summary `Panel Settings` action is not compatible with Security Solution ([bug](elastic#168670)), removing them in this PR. Steps to verify: 1. Visit network / hosts / users / rules / alerts page 2. Find a visualization rendered with Lens Embeddable 3. Click on `...`, and find `Panel settings` should not exist  - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e2906ae)
kibanamachine
added a commit
that referenced
this pull request
Jan 4, 2024
…ntext menu (#174183) (#174233) # Backport This will backport the following commits from `main` to `8.12`: - [[SecuritySolution] Disable Panel Settings for visualization context menu (#174183)](#174183) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-04T08:35:05Z","message":"[SecuritySolution] Disable Panel Settings for visualization context menu (#174183)\n\n## Summary\r\n\r\n`Panel Settings` action is not compatible with Security Solution\r\n([bug](#168670)), removing them\r\nin this PR.\r\n\r\nSteps to verify:\r\n1. Visit network / hosts / users / rules / alerts page\r\n2. Find a visualization rendered with Lens Embeddable\r\n3. Click on `...`, and find `Panel settings` should not exist\r\n\r\n\r\n\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e2906aee878b25494acbd02f950fe8d4e4abbc9b","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","Feature:Lens Charts","v8.12.1","v8.13.0"],"title":"[SecuritySolution] Disable Panel Settings for visualization context menu","number":174183,"url":"https://github.com/elastic/kibana/pull/174183","mergeCommit":{"message":"[SecuritySolution] Disable Panel Settings for visualization context menu (#174183)\n\n## Summary\r\n\r\n`Panel Settings` action is not compatible with Security Solution\r\n([bug](#168670)), removing them\r\nin this PR.\r\n\r\nSteps to verify:\r\n1. Visit network / hosts / users / rules / alerts page\r\n2. Find a visualization rendered with Lens Embeddable\r\n3. Click on `...`, and find `Panel settings` should not exist\r\n\r\n\r\n\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e2906aee878b25494acbd02f950fe8d4e4abbc9b"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174183","number":174183,"mergeCommit":{"message":"[SecuritySolution] Disable Panel Settings for visualization context menu (#174183)\n\n## Summary\r\n\r\n`Panel Settings` action is not compatible with Security Solution\r\n([bug](#168670)), removing them\r\nin this PR.\r\n\r\nSteps to verify:\r\n1. Visit network / hosts / users / rules / alerts page\r\n2. Find a visualization rendered with Lens Embeddable\r\n3. Click on `...`, and find `Panel settings` should not exist\r\n\r\n\r\n\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e2906aee878b25494acbd02f950fe8d4e4abbc9b"}}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Panel Settingsaction is not compatible with Security Solution (bug), removing them in this PR according to the advised solution here.Steps to verify:
..., and findPanel settingsshould not exist