Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update page for missing Short URL (#171679)" #172334

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 1, 2023

@jbudz jbudz marked this pull request as ready for review December 1, 2023 01:40
@jbudz jbudz requested review from a team as code owners December 1, 2023 01:40
@jbudz jbudz merged commit 6fceda6 into elastic:main Dec 1, 2023
7 of 17 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 1, 2023
@jbudz jbudz mentioned this pull request Dec 1, 2023
6 tasks
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 1, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / Agents fleet_upgrade_agent multiple agents should set a long expiration time when the start_time is set to now (immediate rollout period)
  • [job] [logs] FTR Configs #55 / Agents fleet_upgrade_agent multiple agents should set a long expiration time when the start_time is set to now (immediate rollout period)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 78 73 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
share 7.3KB 5.6KB -1.7KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5661 +5661
total size - 5.9MB +5.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 52.4KB 52.2KB -180.0B
Unknown metric groups

async chunk count

id before after diff
share 3 1 -2

ESLint disabled line counts

id before after diff
share 8 7 -1

miscellaneous assets size

id before after diff
share 387.0KB 0.0B -387.0KB

Total ESLint disabled count

id before after diff
share 10 9 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants