Update page for missing Short URL #171679

tsullivan · 2023-11-21T19:07:52Z

Summary

Closes #169935

Screenshots

Before

After

Testing

Create a simple dashboard
Use the Share > Short URL feature to create a short link to the dashboard.
Copy the shortened URL link to the clipboard, create a browser bookmark using the link.
Navigate to Saved Objects Management and delete the backing saved object of the short link
Click the new bookmark to try to open the shortened URL
Land on this new page

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

MichaelMarcialis · 2023-11-27T16:17:54Z

Thanks for putting this together, @tsullivan. Per your request, I've taken a look at this and the originating issue posted by @vadimkibana. Is there a compelling reason to not simply use the standard Kibana 404 error here? If I'm attempting to navigate to a saved object that no longer exists (via short or long URL), this is what I would expect to happen.

…fix'

Dosant · 2023-11-30T12:11:12Z

src/plugins/share/public/url_service/redirect/components/empty_prompt.tsx

+
+const defaultBody = i18n.translate('share.urlService.redirect.components.Error.body', {
+  defaultMessage:
+    'The stored URL for this link could not be opened. This could be due to lost Kibana Saved Object data.',


I think the text could be improved.
I like the text from the screenshot better #171679 (comment)

Also the URL might be broken because it just was incorrect (e.g. mistaken when manually typed or not fully copied)

Maybe something like Sorry, the object you're looking for can't be found at this URL. It might have been removed or maybe it never existed.

Dosant · 2023-11-30T12:12:08Z

src/plugins/share/public/url_service/redirect/components/empty_prompt.tsx

+  // Using the current URL containing "/app/r/", make a URL to the root basePath
+  // by trimming that part to end up at the Home app or project home.
+  const currentUrl = window.location.href;
+  const newUrl = currentUrl.replace(/\/app\/r\/.*/, '');


Why wouldn't we use home href from settings instead?

++ to use the defaultRoute from settings, prepended with the app basePath

beac26f

Dosant

Looks good apart from suggestion to improve copy and if '/' redirects to defaultRoute from uiSettings

kibana-ci · 2023-11-30T21:22:47Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: beac26f

Failed CI Steps

FTR Configs #78

Test Failures

[job] [logs] FTR Configs #78 / serverless search UI Importing an existing dashboard "after all" hook for "does not show the unsaved changes badge in edit mode"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`share`	73	78	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`share`	5.6KB	7.3KB	+1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`share`	52.2KB	52.4KB	+180.0B

Unknown metric groups

async chunk count

id	before	after	diff
`share`	1	3	+2

ESLint disabled line counts

id	before	after	diff
`share`	7	8	+1

miscellaneous assets size

id	before	after	diff
`share`	0.0B	387.0KB	⚠️ +387.0KB

Total ESLint disabled count

id	before	after	diff
`share`	9	10	+1

History

💚 Build #180287 succeeded b2e94a4
💔 Build #180243 failed e8862974472ee7fedd979145b80347f5a5a318a1
💔 Build #180127 failed 15b06af
💔 Build #179824 failed c285b77
💛 Build #179805 was flaky e5813ec
💚 Build #179733 succeeded b0f932a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

This reverts commit e6f3f06.

This reverts commit e6f3f06. See https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/3610#018c22ec-6c1e-4b63-92de-58d63d688f94

jbudz · 2023-12-01T01:42:42Z

Hey, sorry this had to be reverted with #172334. The canvas shareable runtime build is skipped on pull requests by default, but had a build failure later. The build can be opted-in with the ci:build-canvas-shareable-runtime label.

Logs are available at https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/3610#018c22ec-6c1e-4b63-92de-58d63d688f94

## Summary This PR re-opens #171679 which had to be reverted due to CI instability at the time it was originally mergted. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

tsullivan force-pushed the short-urls/new-error-page branch from 946c016 to c3175c0 Compare November 21, 2023 19:09

tsullivan changed the title ~~Short urls/new error page~~ Better Short URL missing link redirection error Nov 21, 2023

tsullivan changed the title ~~Better Short URL missing link redirection error~~ Update Short URL missing link page Nov 21, 2023

tsullivan changed the title ~~Update Short URL missing link page~~ Update page for missing Short URL Nov 21, 2023

tsullivan added 2 commits November 28, 2023 11:00

[SharedUX] Update page for missing Short URL

6adeb1b

Use SharedUX empty prompt

3195a3b

tsullivan force-pushed the short-urls/new-error-page branch 2 times, most recently from 90fdc2a to 3195a3b Compare November 28, 2023 18:42

tsullivan and others added 4 commits November 28, 2023 11:43

Merge branch 'main' into short-urls/new-error-page

a1572bb

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b0f932a

…fix'

Merge branch 'main' into short-urls/new-error-page

e5813ec

functional test for short url 404

c285b77

tsullivan force-pushed the short-urls/new-error-page branch from 6e62725 to c285b77 Compare November 29, 2023 00:09

tsullivan marked this pull request as ready for review November 29, 2023 00:10

tsullivan requested review from a team as code owners November 29, 2023 00:10

tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Nov 29, 2023

tsullivan self-assigned this Nov 29, 2023

Merge branch 'main' into short-urls/new-error-page

15b06af

delanni approved these changes Nov 29, 2023

View reviewed changes

tsullivan requested a review from a team as a code owner November 29, 2023 20:06

functional test

24bdc5d

tsullivan force-pushed the short-urls/new-error-page branch from e886297 to 24bdc5d Compare November 29, 2023 21:07

tsullivan removed the request for review from a team November 29, 2023 21:07

tsullivan and others added 2 commits November 29, 2023 14:12

Merge branch 'main' into short-urls/new-error-page

9a1ed44

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b2e94a4

…fix'

Dosant reviewed Nov 30, 2023

View reviewed changes

Dosant approved these changes Nov 30, 2023

View reviewed changes

Merge branch 'main' into short-urls/new-error-page

6482582

tsullivan added 2 commits November 30, 2023 12:46

Update to wording

5b1f254

Get homeHref from uiSettings

beac26f

tsullivan enabled auto-merge (squash) November 30, 2023 20:04

tsullivan merged commit e6f3f06 into elastic:main Nov 30, 2023
32 checks passed

kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 30, 2023

jbudz added a commit to jbudz/kibana that referenced this pull request Dec 1, 2023

Revert "Update page for missing Short URL (elastic#171679)"

1730d28

This reverts commit e6f3f06.

jbudz added a commit that referenced this pull request Dec 1, 2023

Revert "Update page for missing Short URL (#171679)" (#172334)

6fceda6

This reverts commit e6f3f06. See https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/3610#018c22ec-6c1e-4b63-92de-58d63d688f94

jbudz added the reverted label Dec 1, 2023

This was referenced Dec 1, 2023

Better Short URL missing link redirection error #169935

Closed

Update page for missing Short URL Part II #172422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update page for missing Short URL #171679

Update page for missing Short URL #171679

tsullivan commented Nov 21, 2023 •

edited

Loading

MichaelMarcialis commented Nov 27, 2023

Dosant Nov 30, 2023

Dosant Nov 30, 2023

Dosant Nov 30, 2023

tsullivan Nov 30, 2023

Dosant left a comment •

edited

Loading

kibana-ci commented Nov 30, 2023

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

jbudz commented Dec 1, 2023 •

edited

Loading

Update page for missing Short URL #171679

Update page for missing Short URL #171679

Conversation

tsullivan commented Nov 21, 2023 • edited Loading

Summary

Screenshots

Testing

Checklist

MichaelMarcialis commented Nov 27, 2023

Dosant Nov 30, 2023

Choose a reason for hiding this comment

Dosant Nov 30, 2023

Choose a reason for hiding this comment

Dosant Nov 30, 2023

Choose a reason for hiding this comment

tsullivan Nov 30, 2023

Choose a reason for hiding this comment

Dosant left a comment • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Nov 30, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

History

jbudz commented Dec 1, 2023 • edited Loading

tsullivan commented Nov 21, 2023 •

edited

Loading

Dosant left a comment •

edited

Loading

jbudz commented Dec 1, 2023 •

edited

Loading