Event log shows a failure when ruleResultService.addLastRunError adds an error

[ersin-erdal]

Resolves: #174035

As the new lastRun status holder for rule execution can set the outcome of a successful execution as failed
We have to do the same for the old executionStatus as well.

This PR, sets rule execution status as error when there are error messages reported by the ruleResultService.addLastRunError, even if no errors are thrown!
So the event-log and task metrics shows the correct results.

To verify

Please follow the steps in the issue to reproduce.

[ersin-erdal]

/ci

[ersin-erdal]

/ci

[ersin-erdal]

/ci

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[pmuellr]

We should really add a function test for this, but I understand we're in a bit of a crunch - if that's too much for now, let's open an issue to add one.

[pmuellr]

Everything looks good here, except I'm seeing the TM metrics show an error from the rule I instrumented, to show up as a USER error, not framework:

          "alerting:__index-threshold": {
            "success": 0,
            "not_timed_out": 44,
            "total": 44,
            "total_errors": 44,
            "user_errors": 44,
            "framework_errors": 0
          },

I instrumented index threshold rule by adding a throw new Error('artificial error for testing') - so I'm not sure if in that case it's ok for it to be a user error or not. Seems likely, but thought I'd mention it.

update: this is expected. The code to set the user to be framework is only when they added the addLastRunError, but didn't actually throw an error

[pmuellr]

LGTM, beyond adding a function test (via separate issue is fine).

Tested with the scenario described in the referenced issue, as well as an instrumented executor that explicitly throws errors - works as expected both way ...

[ersin-erdal]

LGTM, beyond adding a function test (via separate issue is fine).

Tested with the scenario described in the referenced issue, as well as an instrumented executor that explicitly throws errors - works as expected both way ...

Created a PR to align the error types: #179656

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 96f5e4f

Metrics [docs]

✅ unchanged

History

• 💚 Build #199965 succeeded ff3b58e
• 💚 Build #199880 succeeded 1dbc37d
• 💚 Build #199761 succeeded 08cd9cc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ersin-erdal