Set ruleType thrown errors as Framework error #179656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
added
release_note:skip
|
/ci |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @ersin-erdal |
pmuellr
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
LGTM; tested as with the previous PR, can now see the framework vs user errors :-)
A little concerned about the lack of needed changes to function tests! Based on lack of need to change function tests for the previous PR as well, let's open an issue to add some tests for this functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on PR of #174035.
As we decided to set the errors reported by addLastRunError as Framework Error, this PR aligns the other errors thrown by the ruleTypes by switching from USER to FRAMEWORK.
To verify
Throw an error in any of the ruleType executor, and expect to see framework error metrics in :
/api/task_manager/metrics?reset=false