-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC - independent solution repo structure #179710
Draft
lukeelmers
wants to merge
10
commits into
elastic:main
Choose a base branch
from
lukeelmers:poc/solution-boundaries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
March 29, 2024 19:33
3c0f4a6
to
cdb2f2a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
March 29, 2024 19:43
cdb2f2a
to
0e83e3b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
4 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
2 times, most recently
from
April 2, 2024 18:06
34faf4f
to
f54bcbe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
April 2, 2024 18:33
f54bcbe
to
33bf421
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
April 2, 2024 19:04
33bf421
to
418b13c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
April 2, 2024 21:30
340afc5
to
8e665d0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
May 15, 2024 02:03
193c5b5
to
1f290a9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
💔 Build Failed
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
lukeelmers
force-pushed
the
poc/solution-boundaries
branch
from
May 15, 2024 02:42
1f290a9
to
7077867
Compare
This was referenced Oct 8, 2024
gsoldevila
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Follow-up of #195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in #194810, updating plugins that were considered to be solution-specific in Luke's [PoC](#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins.
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Nov 7, 2024
…95375) ## Summary Follow-up of elastic#195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in elastic#194810, updating plugins that were considered to be solution-specific in Luke's [PoC](elastic#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins. (cherry picked from commit a5517d9) # Conflicts: # src/plugins/maps_ems/kibana.jsonc # x-pack/plugins/file_upload/kibana.jsonc # x-pack/plugins/maps/kibana.jsonc
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Nov 7, 2024
…95375) ## Summary Follow-up of elastic#195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in elastic#194810, updating plugins that were considered to be solution-specific in Luke's [PoC](elastic#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins. (cherry picked from commit a5517d9) # Conflicts: # src/plugins/maps_ems/kibana.jsonc # x-pack/plugins/file_upload/kibana.jsonc # x-pack/plugins/maps/kibana.jsonc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely don't merge this
This is a proof-of-concept which explores what it would look like to make solutions more independent by restructuring the repo in a way that enforces new plugin-level boundaries. These boundaries prevent solution plugins from having dependencies on each other, forcing any shared dependencies to live in the platform:
These boundaries are enforced by the directory structure of the repo. For illustrative purposes, this is the directory structure used in this PR (the final structure would likely be a bit different):
Plugins are only allowed to have dependencies on plugins which exist in the
platform
directory, so for example, a plugin insecurity
could not depend on another inobservability
.Plugins which are leftover in
src/plugins
andx-pack/plugins
were identified as problematic because they don't currently adhere to these restrictions and would need to be refactored or have bits relocated toplatform
. These include:The enforcement logic in 7077867 may not be how we'd actually implement this in production, especially if we were looking to add similar logic to packages... in that case it would be worth considering strategies for making this more generalized.
Follow-up tasks not done here
src/core
->src/platform/core
(requires a lot of changes to hard-coded paths)kbn_references
?)