Address some of the no_group_crossing dependencies
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
force-pushed
the
kbn-team-1079-fix-illegal-deps-1
branch
3 times, most recently
from
8146039 to
14d8f4f
Compare
gsoldevila
force-pushed
the
kbn-team-1079-fix-illegal-deps-1
branch
from
7bef73e to
02b2516
Compare
gsoldevila
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ted features (elastic#198656) ## Summary This PR ensures that we don’t expose UI capabilities for deprecated features since they’re unnecessary, and the code should rely on the UI capabilities of the replacement features instead. Additionally, this PR transforms the `disabledFeatures` property of Space objects returned from our programmatic and HTTP APIs to replace any deprecated feature IDs with the IDs of their replacement features, ensuring that feature visibility toggles work for deprecated features as well. ## How to test 1. Run Kibana FTR server with the following config (registers test deprecated features): ```shell node scripts/functional_tests_server.js --config x-pack/test/security_api_integration/features.config.ts ``` 2. Once server is up and running create Space with the `case_1_feature_a` **deprecated** feature disabled: ```shell curl 'http://localhost:5620/api/spaces/space' -u elastic:changeme \ -X POST -H 'Content-Type: application/json' -H 'kbn-version: 9.0.0' \ --data-raw '{"name":"space-alpha","id":"space-alpha","initials":"s","color":"#D6BF57","disabledFeatures":["case_1_feature_a"],"imageUrl":""}' ``` 3. Log in to Kibana and [navigate to a Space `space-alpha`](http://localhost:5620/app/management/kibana/spaces/edit/space-alpha) you've just created. Observe that deprecated `Case #1 feature A` (`case_1_feature_a`) isn't displayed, and instead you should see that replaces deprecated one - `Case #1 feature B` (`case_1_feature_b`):  Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gsoldevila
pushed a commit
that referenced
this pull request
Nov 7, 2024
…eprecated features (elastic#198656) (elastic#199147) # Backport This will backport the following commits from `main` to `8.x`: - [fix(security, features): do not expose UI capabilities of the deprecated features (elastic#198656)](elastic#198656) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"aleh.zasypkin@elastic.co"},"sourceCommit":{"committedDate":"2024-11-06T14:06:39Z","message":"fix(security, features): do not expose UI capabilities of the deprecated features (elastic#198656)\n\n## Summary\r\n\r\nThis PR ensures that we don’t expose UI capabilities for deprecated\r\nfeatures since they’re unnecessary, and the code should rely on the UI\r\ncapabilities of the replacement features instead.\r\n\r\nAdditionally, this PR transforms the `disabledFeatures` property of\r\nSpace objects returned from our programmatic and HTTP APIs to replace\r\nany deprecated feature IDs with the IDs of their replacement features,\r\nensuring that feature visibility toggles work for deprecated features as\r\nwell.\r\n\r\n## How to test\r\n\r\n1. Run Kibana FTR server with the following config (registers test\r\ndeprecated features):\r\n```shell\r\nnode scripts/functional_tests_server.js --config x-pack/test/security_api_integration/features.config.ts\r\n```\r\n2. Once server is up and running create Space with the\r\n`case_1_feature_a` **deprecated** feature disabled:\r\n```shell\r\ncurl 'http://localhost:5620/api/spaces/space' -u elastic:changeme \\\r\n -X POST -H 'Content-Type: application/json' -H 'kbn-version: 9.0.0' \\\r\n --data-raw '{\"name\":\"space-alpha\",\"id\":\"space-alpha\",\"initials\":\"s\",\"color\":\"#D6BF57\",\"disabledFeatures\":[\"case_1_feature_a\"],\"imageUrl\":\"\"}'\r\n```\r\n3. Log in to Kibana and [navigate to a Space\r\n`space-alpha`](http://localhost:5620/app/management/kibana/spaces/edit/space-alpha)\r\nyou've just created. Observe that deprecated `Case #1 feature A`\r\n(`case_1_feature_a`) isn't displayed, and instead you should see that\r\nreplaces deprecated one - `Case #1 feature B` (`case_1_feature_b`):\r\n\r\n\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"deeb9fe32af717a883727aed7d83c6106d8d839f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","Feature:Security/Authorization","v9.0.0","backport:prev-major"],"title":"fix(security, features): do not expose UI capabilities of the deprecated features","number":198656,"url":"https://github.com/elastic/kibana/pull/198656","mergeCommit":{"message":"fix(security, features): do not expose UI capabilities of the deprecated features (elastic#198656)\n\n## Summary\r\n\r\nThis PR ensures that we don’t expose UI capabilities for deprecated\r\nfeatures since they’re unnecessary, and the code should rely on the UI\r\ncapabilities of the replacement features instead.\r\n\r\nAdditionally, this PR transforms the `disabledFeatures` property of\r\nSpace objects returned from our programmatic and HTTP APIs to replace\r\nany deprecated feature IDs with the IDs of their replacement features,\r\nensuring that feature visibility toggles work for deprecated features as\r\nwell.\r\n\r\n## How to test\r\n\r\n1. Run Kibana FTR server with the following config (registers test\r\ndeprecated features):\r\n```shell\r\nnode scripts/functional_tests_server.js --config x-pack/test/security_api_integration/features.config.ts\r\n```\r\n2. Once server is up and running create Space with the\r\n`case_1_feature_a` **deprecated** feature disabled:\r\n```shell\r\ncurl 'http://localhost:5620/api/spaces/space' -u elastic:changeme \\\r\n -X POST -H 'Content-Type: application/json' -H 'kbn-version: 9.0.0' \\\r\n --data-raw '{\"name\":\"space-alpha\",\"id\":\"space-alpha\",\"initials\":\"s\",\"color\":\"#D6BF57\",\"disabledFeatures\":[\"case_1_feature_a\"],\"imageUrl\":\"\"}'\r\n```\r\n3. Log in to Kibana and [navigate to a Space\r\n`space-alpha`](http://localhost:5620/app/management/kibana/spaces/edit/space-alpha)\r\nyou've just created. Observe that deprecated `Case #1 feature A`\r\n(`case_1_feature_a`) isn't displayed, and instead you should see that\r\nreplaces deprecated one - `Case #1 feature B` (`case_1_feature_b`):\r\n\r\n\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"deeb9fe32af717a883727aed7d83c6106d8d839f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198656","number":198656,"mergeCommit":{"message":"fix(security, features): do not expose UI capabilities of the deprecated features (elastic#198656)\n\n## Summary\r\n\r\nThis PR ensures that we don’t expose UI capabilities for deprecated\r\nfeatures since they’re unnecessary, and the code should rely on the UI\r\ncapabilities of the replacement features instead.\r\n\r\nAdditionally, this PR transforms the `disabledFeatures` property of\r\nSpace objects returned from our programmatic and HTTP APIs to replace\r\nany deprecated feature IDs with the IDs of their replacement features,\r\nensuring that feature visibility toggles work for deprecated features as\r\nwell.\r\n\r\n## How to test\r\n\r\n1. Run Kibana FTR server with the following config (registers test\r\ndeprecated features):\r\n```shell\r\nnode scripts/functional_tests_server.js --config x-pack/test/security_api_integration/features.config.ts\r\n```\r\n2. Once server is up and running create Space with the\r\n`case_1_feature_a` **deprecated** feature disabled:\r\n```shell\r\ncurl 'http://localhost:5620/api/spaces/space' -u elastic:changeme \\\r\n -X POST -H 'Content-Type: application/json' -H 'kbn-version: 9.0.0' \\\r\n --data-raw '{\"name\":\"space-alpha\",\"id\":\"space-alpha\",\"initials\":\"s\",\"color\":\"#D6BF57\",\"disabledFeatures\":[\"case_1_feature_a\"],\"imageUrl\":\"\"}'\r\n```\r\n3. Log in to Kibana and [navigate to a Space\r\n`space-alpha`](http://localhost:5620/app/management/kibana/spaces/edit/space-alpha)\r\nyou've just created. Observe that deprecated `Case #1 feature A`\r\n(`case_1_feature_a`) isn't displayed, and instead you should see that\r\nreplaces deprecated one - `Case #1 feature B` (`case_1_feature_b`):\r\n\r\n\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"deeb9fe32af717a883727aed7d83c6106d8d839f"}}]}] BACKPORT--> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@elastic.co>
gsoldevila
added a commit
that referenced
this pull request
Nov 7, 2024
…95375) ## Summary Follow-up of elastic#195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in elastic#194810, updating plugins that were considered to be solution-specific in Luke's [PoC](elastic#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins. (cherry picked from commit a5517d9) # Conflicts: # src/plugins/maps_ems/kibana.jsonc # x-pack/plugins/file_upload/kibana.jsonc # x-pack/plugins/maps/kibana.jsonc
gsoldevila
added a commit
that referenced
this pull request
Nov 7, 2024
…95375) ## Summary Follow-up of elastic#195367 As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in elastic#194810, updating plugins that were considered to be solution-specific in Luke's [PoC](elastic#179710). This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies. As soon as they are resolved, we can proceed to classify solutions' plugins. (cherry picked from commit a5517d9) # Conflicts: # src/plugins/maps_ems/kibana.jsonc # x-pack/plugins/file_upload/kibana.jsonc # x-pack/plugins/maps/kibana.jsonc
gsoldevila
added a commit
that referenced
this pull request
Nov 8, 2024
…stic#195375) (elastic#199268) # Backport This will backport the following commits from `main` to `8.x`: - [[Sustainable Kibana Architecture] Update plugins (wave #1) (elastic#195375)](elastic#195375) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T14:05:27Z","message":"[Sustainable Kibana Architecture] Update plugins (wave #1) (elastic#195375)\n\n## Summary\r\n\r\nFollow-up of https://github.com/elastic/kibana/pull/195367\r\nAs part of the Sustainable Kibana Architecture initiative, this PR\r\nleverages the mechanisms and concepts introduced in\r\nhttps://github.com/elastic/pull/194810, updating plugins that\r\nwere considered to be solution-specific in Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis might trigger linting rule violations in CI, and help uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as they are resolved, we can proceed to classify solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Embedding","Feature:ExpressionLanguage","release_note:skip","Feature:Drilldowns","Team:Fleet","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"number":195375,"url":"https://github.com/elastic/kibana/pull/195375","mergeCommit":{"message":"[Sustainable Kibana Architecture] Update plugins (wave #1) (elastic#195375)\n\n## Summary\r\n\r\nFollow-up of https://github.com/elastic/kibana/pull/195367\r\nAs part of the Sustainable Kibana Architecture initiative, this PR\r\nleverages the mechanisms and concepts introduced in\r\nhttps://github.com/elastic/pull/194810, updating plugins that\r\nwere considered to be solution-specific in Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis might trigger linting rule violations in CI, and help uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as they are resolved, we can proceed to classify solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195375","number":195375,"mergeCommit":{"message":"[Sustainable Kibana Architecture] Update plugins (wave #1) (elastic#195375)\n\n## Summary\r\n\r\nFollow-up of https://github.com/elastic/kibana/pull/195367\r\nAs part of the Sustainable Kibana Architecture initiative, this PR\r\nleverages the mechanisms and concepts introduced in\r\nhttps://github.com/elastic/pull/194810, updating plugins that\r\nwere considered to be solution-specific in Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis might trigger linting rule violations in CI, and help uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as they are resolved, we can proceed to classify solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR relocates some plugins and packages that are incorrectly categorised, aiming at reducing inter-solution dependencies. It also fixes some incorrect import statements that introduce unnecessary dependencies with other components.