-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bsearch endpoint #197150
Remove bsearch endpoint #197150
Conversation
…na into remove_bfetch_use_search
…kibana into remove_bfetch_remove_bsearch
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/tsconfig.json
and x-pack/test_serverless/tsconfig.json
changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visualizations changes look good (I didn't test in depth as we're more in charge of aggs in data plugin, while search is more in discovery hands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good! I don't see why there'd be any impact from these changes, but I'll do some testing tomorrow to confirm before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed no issues testing locally with multiple analytics apps, LGTM 👍 We're getting closer!
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @lukasolson |
Summary
Relies on #196962.
Part of #186139.
Removes the
api/internal/bsearch
endpoint. Updates theSearchInterceptor
to no longer use this endpoint.Checklist