Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bsearch endpoint #197150

Merged
merged 31 commits into from
Dec 6, 2024
Merged

Conversation

lukasolson
Copy link
Member

Summary

Relies on #196962.
Part of #186139.

Removes the api/internal/bsearch endpoint. Updates the SearchInterceptor to no longer use this endpoint.

Checklist

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 21, 2024
@lukasolson lukasolson self-assigned this Oct 21, 2024
@lukasolson lukasolson mentioned this pull request Nov 5, 2024
6 tasks
@lukasolson lukasolson marked this pull request as ready for review December 2, 2024 22:57
@lukasolson lukasolson requested review from a team as code owners December 2, 2024 22:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/tsconfig.json and x-pack/test_serverless/tsconfig.json changes LGTM

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualizations changes look good (I didn't test in depth as we're more in charge of aggs in data plugin, while search is more in discovery hands)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good! I don't see why there'd be any impact from these changes, but I'll do some testing tomorrow to confirm before approving.

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed no issues testing locally with multiple analytics apps, LGTM 👍 We're getting closer!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 525 523 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 421.8KB 420.7KB -1.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
data 57 56 -1

Total ESLint disabled count

id before after diff
data 59 58 -1

History

cc @lukasolson

@lukasolson lukasolson merged commit efe06a3 into elastic:main Dec 6, 2024
9 checks passed
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants