Remove bfetch #199066

lukasolson · 2024-11-05T22:42:41Z

Summary

Relies on #196962 and #197150.
Resolves #186139.

Removes the bfetch plugin & updates documentation accordingly.

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

Risk Matrix

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately
This will appear in the Release Notes and follow the guidelines

…fix'

…na into remove_bfetch_use_search

…arch

elasticmachine · 2024-11-05T22:42:45Z

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

Click to trigger kibana-pull-request for this PR!
Click to trigger kibana-deploy-project-from-pr for this PR!

github-actions · 2024-11-05T22:42:58Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…ove_bfetch

…-fix'

…kibana into remove_bfetch_remove_bsearch

…ove_bfetch

elasticmachine · 2024-12-13T21:45:20Z

💔 Build Failed

Buildkite Build
Commit: 8bd4999

Failed CI Steps

Build and Validate Next Docs

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/management-settings-ids`	136	134	-2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	3.5MB	3.5MB	-390.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/management-settings-ids`	137	135	-2

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-src`	59	57	-2

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-src`	65	63	-2

History

cc @lukasolson

## Summary Part of #186139. First step of breaking up #199066 into smaller pieces. Removes the bfetch explorer example plugin.

lukasolson · 2024-12-18T21:33:36Z

Closing in favor of #204285

## Summary Part of elastic#186139. First step of breaking up elastic#199066 into smaller pieces. Removes the bfetch explorer example plugin.

## Summary Part of #186139. Relies on #204284. Second step of breaking up #199066 into smaller pieces. Removes the bfetch and bfetch-error plugins. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

lukasolson and others added 23 commits October 18, 2024 14:53

Move consumers off bsearch endpoint

bd1cf6e

[CI] Auto-commit changed files from 'node scripts/notice'

625d6e4

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

096bd81

…fix'

Merge branch 'main' into remove_bfetch_use_search

5ad2b10

Remove bsearch endpoint

8ca2078

[CI] Auto-commit changed files from 'node scripts/notice'

8ab6a24

Merge branch 'main' into remove_bfetch_use_search

bd38a1c

Merge branch 'main' into remove_bfetch_use_search

f2a9a21

Merge branch 'main' into remove_bfetch_use_search

c59e9bd

Merge branch 'main' into remove_bfetch_remove_bsearch

8dd35df

Fix search interceptor tests

bd7ba71

Remove bsearch API integration tests

43f1bb6

Merge branch 'main' into remove_bfetch_use_search

a6d4964

Merge branch 'main' into remove_bfetch_use_search

a38f62f

Merge branch 'main' into remove_bfetch_use_search

50b03da

Merge branch 'main' into remove_bfetch_use_search

ee8ce61

Review feedback

6c8614f

Merge branch 'remove_bfetch_use_search' of github.com:lukasolson/kiba…

08935b3

…na into remove_bfetch_use_search

Merge branch 'remove_bfetch_use_search' into remove_bfetch_remove_bse…

6f9edea

…arch

Remove bsearch tests

5b663c2

Merge branch 'main' into remove_bfetch_remove_bsearch

ad310bb

Don't use bfetch route version number

364088a

Remove bfetch plugin

b2a7471

lukasolson added Feature:Search Querying infrastructure in Kibana release_note:breaking backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 5, 2024

lukasolson self-assigned this Nov 5, 2024

lukasolson and others added 22 commits November 19, 2024 16:30

Merge branch 'main' into remove_bfetch_remove_bsearch

4c26279

Merge branch 'remove_bfetch_remove_bsearch' into remove_bfetch

354c6e5

Merge branch 'remove_bfetch' of github.com:lukasolson/kibana into rem…

f89263c

…ove_bfetch

[CI] Auto-commit changed files from 'node scripts/notice'

0bde361

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

09e892c

…-fix'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

501e278

…-fix'

Merge branch 'main' into remove_bfetch_remove_bsearch

add8bbe

Merge branch 'remove_bfetch_remove_bsearch' of github.com:lukasolson/…

8eef8c5

…kibana into remove_bfetch_remove_bsearch

Update search interceptor tests and fix types

23eb8a9

Merge branch 'main' into remove_bfetch_remove_bsearch`

252fe87

Merge branch 'remove_bfetch_remove_bsearch' into remove_bfetch

918bc59

Merge branch 'remove_bfetch' of github.com:lukasolson/kibana into rem…

7424c44

…ove_bfetch

telemetry_check changes

8880779

type & test fixes

fd4e9d7

Merge branch 'main' into remove_bfetch

9898090

Fix reference to removed code

ebfc60b

Merge branch 'main' into remove_bfetch

568080b

Revert telemetry changes

a6fee64

Merge branch 'main' into remove_bfetch

3011ee9

Merge branch 'main' of github.com:elastic/kibana into remove_bfetch

28d35d4

Fix tests

deacd8d

Merge branch 'main' into remove_bfetch

8bd4999

lukasolson mentioned this pull request Dec 13, 2024

Remove bfetch explorer example plugin #204284

Merged

lukasolson mentioned this pull request Dec 13, 2024

Remove bfetch plugin #204285

Merged

lukasolson added a commit that referenced this pull request Dec 16, 2024

Remove bfetch explorer example plugin (#204284)

8ad0eb4

## Summary Part of #186139. First step of breaking up #199066 into smaller pieces. Removes the bfetch explorer example plugin.

lukasolson closed this Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove bfetch #199066

Remove bfetch #199066

lukasolson commented Nov 5, 2024 •

edited

Loading

elasticmachine commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024

elasticmachine commented Dec 13, 2024 •

edited

Loading

API count

ESLint disabled line counts

Total ESLint disabled count

lukasolson commented Dec 18, 2024

Remove bfetch #199066

Remove bfetch #199066

Conversation

lukasolson commented Nov 5, 2024 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

elasticmachine commented Nov 5, 2024 • edited Loading

github-actions bot commented Nov 5, 2024

elasticmachine commented Dec 13, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

lukasolson commented Dec 18, 2024

lukasolson commented Nov 5, 2024 •

edited

Loading

elasticmachine commented Nov 5, 2024 •

edited

Loading

elasticmachine commented Dec 13, 2024 •

edited

Loading