-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security][D4C] Hide K8S #201062
[Cloud Security][D4C] Hide K8S #201062
Conversation
/ci |
/ci |
/ci |
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
x-pack/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts
Outdated
Show resolved
Hide resolved
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I updated the description to reflect you actually deleted the tests (which is a good idea) rather than keeping them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12020616153 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
## Summary This PR is to hide K8S so User won't be able to access K8S Dashboard via navigating to it from the page or by direct URL, also deleting Cypress tests related to this --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12041560306 |
## Summary This PR is to hide K8S so User won't be able to access K8S Dashboard via navigating to it from the page or by direct URL, also deleting Cypress tests related to this --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6d91a7c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security][D4C] Hide K8S (#201062)](#201062) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-11-25T23:24:17Z","message":"[Cloud Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating to it from the page or by direct URL,\r\nalso deleting Cypress tests related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.18.0"],"title":"[Cloud Security][D4C] Hide K8S","number":201062,"url":"https://github.com/elastic/kibana/pull/201062","mergeCommit":{"message":"[Cloud Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating to it from the page or by direct URL,\r\nalso deleting Cypress tests related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201062","number":201062,"mergeCommit":{"message":"[Cloud Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating to it from the page or by direct URL,\r\nalso deleting Cypress tests related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
## Summary This PR is to hide K8S so User won't be able to access K8S Dashboard via navigating to it from the page or by direct URL, also deleting Cypress tests related to this --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR is to hide K8S so User won't be able to access K8S Dashboard via navigating to it from the page or by direct URL,
also deleting Cypress tests related to this