Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][D4C] Hide K8S #201062

Merged
merged 11 commits into from
Nov 25, 2024
Merged

[Cloud Security][D4C] Hide K8S #201062

merged 11 commits into from
Nov 25, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Nov 21, 2024

Summary

This PR is to hide K8S so User won't be able to access K8S Dashboard via navigating to it from the page or by direct URL,
also deleting Cypress tests related to this

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart animehart marked this pull request as ready for review November 21, 2024 15:03
@animehart animehart requested review from a team as code owners November 21, 2024 15:03
@animehart animehart added v8.18.0 Team:Cloud Security Cloud Security team related labels Nov 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 21, 2024
@animehart animehart requested a review from kapral18 November 21, 2024 23:11
@animehart
Copy link
Contributor Author

/ci

Copy link
Contributor

@albertoblaz albertoblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I updated the description to reflect you actually deleted the tests (which is a good idea) rather than keeping them

Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +50.0B

History

@animehart animehart merged commit 6d91a7c into elastic:main Nov 25, 2024
43 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12020616153

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [WIP] - Unskip threat hunting tests (#195662)

Manual backport

To create the backport manually run:

node scripts/backport --pr 201062

Questions ?

Please refer to the Backport tool documentation

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

This PR is to hide K8S so User won't be able to access K8S Dashboard via
navigating to it from the page or by direct URL,
also deleting Cypress tests related to this

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@animehart animehart added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Nov 27, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12041560306

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2024
## Summary

This PR is to hide K8S so User won't be able to access K8S Dashboard via
navigating to it from the page or by direct URL,
also deleting Cypress tests related to this

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6d91a7c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 27, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security][D4C] Hide K8S
(#201062)](#201062)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-11-25T23:24:17Z","message":"[Cloud
Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to
hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating
to it from the page or by direct URL,\r\nalso deleting Cypress tests
related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor","v8.18.0"],"title":"[Cloud
Security][D4C] Hide
K8S","number":201062,"url":"https://github.com/elastic/kibana/pull/201062","mergeCommit":{"message":"[Cloud
Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to
hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating
to it from the page or by direct URL,\r\nalso deleting Cypress tests
related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201062","number":201062,"mergeCommit":{"message":"[Cloud
Security][D4C] Hide K8S (#201062)\n\n## Summary\r\n\r\nThis PR is to
hide K8S so User won't be able to access K8S Dashboard via\r\nnavigating
to it from the page or by direct URL,\r\nalso deleting Cypress tests
related to this\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d91a7c0659c2a9e65bc963d193e81eb357b669c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

This PR is to hide K8S so User won't be able to access K8S Dashboard via
navigating to it from the page or by direct URL,
also deleting Cypress tests related to this

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants