Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][D4C] Hide K8S #201062

Merged
merged 11 commits into from
Nov 25, 2024
+3 −14
Merged

[Cloud Security][D4C] Hide K8S #201062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c501ee
hiding k8s trying out
animehart Nov 21, 2024
29bcb66
simplify
animehart Nov 21, 2024
3d3b028
clean up
animehart Nov 21, 2024
a7e5d85
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine Nov 21, 2024
209a5d6
Merge branch 'main' into hide-k8s
animehart Nov 21, 2024
b23d902
skipping test
animehart Nov 21, 2024
d02b0ac
Merge branch 'hide-k8s' of github.com:animehart/kibana into hide-k8s
animehart Nov 21, 2024
7b3e10a
removed unused test
animehart Nov 21, 2024
7b3fd20
Merge branch 'main' into hide-k8s
animehart Nov 22, 2024
c2c4540
Merge branch 'main' into hide-k8s
animehart Nov 25, 2024
efde177
Merge branch 'main' into hide-k8s
animehart Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/common/experimental_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const allowedExperimentalValues = Object.freeze({
// FIXME:PT delete?
excludePoliciesInFilterEnabled: false,

kubernetesEnabled: true,
kubernetesEnabled: false,
donutChartEmbeddablesEnabled: false, // Depends on https://github.com/elastic/kibana/issues/136409 item 2 - 6

/**
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/security_solution/public/kubernetes/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import React from 'react';
import { TrackApplicationView } from '@kbn/usage-collection-plugin/public';
import { allowedExperimentalValues } from '../../common';
import { KubernetesContainer } from './pages';

import type { SecuritySubPluginRoutes } from '../app/types';
Expand All @@ -24,7 +25,7 @@ export const KubernetesRoutes = () => (

export const routes: SecuritySubPluginRoutes = [
{
path: KUBERNETES_PATH,
path: allowedExperimentalValues.kubernetesEnabled ? KUBERNETES_PATH : [],
component: KubernetesRoutes,
},
];
12 changes: 0 additions & 12 deletions x-pack/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
DETECTION_RESPONSE,
DASHBOARDS,
CSP_DASHBOARD,
KUBERNETES,
INDICATORS,
BLOCKLIST,
CSP_BENCHMARKS,
Expand Down Expand Up @@ -54,7 +53,6 @@ import {
EXPLORE_URL,
MANAGE_URL,
CSP_DASHBOARD_URL,
KUBERNETES_URL,
BLOCKLIST_URL,
CSP_BENCHMARKS_URL,
CSP_FINDINGS_URL,
Expand Down Expand Up @@ -114,11 +112,6 @@ describe('top-level navigation common to all pages in the Security app', { tags:
cy.url().should('include', ENTITY_ANALYTICS_URL);
});

it('navigates to the Kubernetes page', () => {
navigateFromHeaderTo(KUBERNETES);
cy.url().should('include', KUBERNETES_URL);
});

it('navigates to the CSP dashboard page', () => {
navigateFromHeaderTo(CSP_DASHBOARD);
cy.url().should('include', CSP_DASHBOARD_URL);
Expand Down Expand Up @@ -289,11 +282,6 @@ describe('Serverless side navigation links', { tags: '@serverless' }, () => {
cy.url().should('include', ENTITY_ANALYTICS_URL);
});

it('navigates to the Kubernetes page', () => {
navigateFromHeaderTo(ServerlessHeaders.KUBERNETES, true);
cy.url().should('include', KUBERNETES_URL);
});

it('navigates to the CSP dashboard page', () => {
navigateFromHeaderTo(ServerlessHeaders.CSP_DASHBOARD, true);
cy.url().should('include', CSP_DASHBOARD_URL);
Expand Down