Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-core #201653

Open
wants to merge 186 commits into
base: main
Choose a base branch
from

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Nov 25, 2024

Summary

Start relocating Kibana modules (packages and plugins) to the new folder structure, according to the Kibana Sustainable Architecture initiative.

16 plugin(s) are going to be relocated:

Id Target folder
@kbn/cloud-chat-plugin x-pack/platform/plugins/private/cloud_integrations/cloud_chat
@kbn/cloud-experiments-plugin x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments
@kbn/cloud-full-story-plugin x-pack/platform/plugins/private/cloud_integrations/cloud_full_story
@kbn/cloud-links-plugin x-pack/platform/plugins/private/cloud_integrations/cloud_links
@kbn/cloud-plugin x-pack/platform/plugins/shared/cloud
@kbn/features-plugin x-pack/platform/plugins/shared/features
@kbn/ftr-apis-plugin src/platform/plugins/private/ftr_apis
@kbn/kibana-usage-collection-plugin src/platform/plugins/private/kibana_usage_collection
@kbn/licensing-plugin x-pack/platform/plugins/shared/licensing
@kbn/newsfeed-plugin src/platform/plugins/shared/newsfeed
@kbn/saved-objects-management-plugin src/platform/plugins/shared/saved_objects_management
@kbn/telemetry-collection-manager-plugin src/platform/plugins/shared/telemetry_collection_manager
@kbn/telemetry-collection-xpack-plugin x-pack/platform/plugins/private/telemetry_collection_xpack
@kbn/telemetry-management-section-plugin src/platform/plugins/shared/telemetry_management_section
@kbn/telemetry-plugin src/platform/plugins/shared/telemetry
@kbn/usage-collection-plugin src/platform/plugins/shared/usage_collection

22 package(s) are going to be relocated:

Id Target folder
@kbn/analytics src/platform/packages/shared/kbn-analytics
@kbn/analytics-collection-utils src/platform/packages/private/analytics/utils/analytics_collection_utils
@kbn/apm-config-loader src/platform/packages/private/kbn-apm-config-loader
@kbn/cloud src/platform/packages/shared/cloud
@kbn/config src/platform/packages/shared/kbn-config
@kbn/config-mocks src/platform/packages/private/kbn-config-mocks
@kbn/config-schema src/platform/packages/shared/kbn-config-schema
@kbn/crypto-browser src/platform/packages/shared/kbn-crypto-browser
@kbn/ebt-tools src/platform/packages/shared/kbn-ebt-tools
@kbn/es-errors src/platform/packages/shared/kbn-es-errors
@kbn/es-types src/platform/packages/shared/kbn-es-types
@kbn/hapi-mocks src/platform/packages/private/kbn-hapi-mocks
@kbn/health-gateway-server src/platform/packages/private/kbn-health-gateway-server
@kbn/i18n src/platform/packages/shared/kbn-i18n
@kbn/i18n-react src/platform/packages/shared/kbn-i18n-react
@kbn/logging src/platform/packages/shared/kbn-logging
@kbn/logging-mocks src/platform/packages/shared/kbn-logging-mocks
@kbn/router-to-openapispec src/platform/packages/shared/kbn-router-to-openapispec
@kbn/server-http-tools src/platform/packages/shared/kbn-server-http-tools
@kbn/std src/platform/packages/shared/kbn-std
@kbn/utility-types src/platform/packages/shared/kbn-utility-types
@kbn/zod src/platform/packages/shared/kbn-zod

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-core-packages-1-10 branch from aadc120 to deb5701 Compare November 26, 2024 15:13
afharo added a commit that referenced this pull request Nov 27, 2024
## Summary

Since we are moving code around, the schema extractor now needs to adapt
to the new directories.

This PR adds new per-solution schemas to the `.telemetryrc.json` files
and adapts FTRs accordingly.

Related #201653

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2024
## Summary

Since we are moving code around, the schema extractor now needs to adapt
to the new directories.

This PR adds new per-solution schemas to the `.telemetryrc.json` files
and adapts FTRs accordingly.

Related elastic#201653

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit dac87ef)
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-core-packages-1-10 branch from deb5701 to c2af66e Compare November 28, 2024 09:58
@gsoldevila gsoldevila requested review from a team and dgieselaar as code owners November 28, 2024 09:58
@afharo afharo force-pushed the kbn-team-1309-move-core-packages-1-10 branch from e2fa618 to 9a88907 Compare December 19, 2024 07:22
@afharo afharo enabled auto-merge (squash) December 19, 2024 15:26
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / isInternalURL with basePath defined should return true if relative path does not escape base path
  • [job] [logs] Jest Tests #14 / isInternalURL with basePath defined should return true if relative path does not escape base path

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [1861bbc]

History

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.